* Re: 06/06: gnu: Add weasyprint.
[not found] ` <20191022150138.819B2209DE@vcs0.savannah.gnu.org>
@ 2019-10-22 20:13 ` Ludovic Courtès
2019-10-22 21:51 ` Tobias Geerinckx-Rice
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2019-10-22 20:13 UTC (permalink / raw)
To: guix-devel, Hartmut Goebel
Hi Hartmut,
guix-commits@gnu.org skribis:
> + (package
> + (name "weasyprint")
> + (version "50")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "WeasyPrint" version))
> + (sha256
> + (base32 "0invs96zvmcr6wh5klj52jrcnr9qg150v9wpmbhcsf3vv1d1hbcw"))
> + (patches (search-patches "weasyprint-library-paths.patch"))))
You forgot to push the patch. Could you add it?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 06/06: gnu: Add weasyprint.
2019-10-22 20:13 ` 06/06: gnu: Add weasyprint Ludovic Courtès
@ 2019-10-22 21:51 ` Tobias Geerinckx-Rice
2019-10-23 8:07 ` Hartmut Goebel
0 siblings, 1 reply; 5+ messages in thread
From: Tobias Geerinckx-Rice @ 2019-10-22 21:51 UTC (permalink / raw)
To: guix-devel; +Cc: Hartmut Goebel
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
Hartmut, Ludo',
Ludovic Courtès 写道：
>> + (patches (search-patches
>> "weasyprint-library-paths.patch"))))
>
> You forgot to push the patch. Could you add it?
I've reverted this patch for now to keep master relatively happy.
Good night!
T G-R
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 06/06: gnu: Add weasyprint.
2019-10-22 21:51 ` Tobias Geerinckx-Rice
@ 2019-10-23 8:07 ` Hartmut Goebel
2019-10-23 14:24 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Hartmut Goebel @ 2019-10-23 8:07 UTC (permalink / raw)
To: Tobias Geerinckx-Rice, guix-devel
[-- Attachment #1.1: Type: text/plain, Size: 467 bytes --]
Am 22.10.19 um 23:51 schrieb Tobias Geerinckx-Rice:
> Ludo:
>> You forgot to push the patch. Could you add it?
>
> I've reverted this patch for now to keep master relatively happy.
>
Ups, soory. New package including the patch in
77e0cebcadc8b96613832e1554e326d48e20f72f
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 06/06: gnu: Add weasyprint.
2019-10-23 8:07 ` Hartmut Goebel
@ 2019-10-23 14:24 ` Ludovic Courtès
2019-10-28 8:37 ` Hartmut Goebel
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2019-10-23 14:24 UTC (permalink / raw)
To: Hartmut Goebel; +Cc: guix-devel
Hi Hartmut,
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
> Am 22.10.19 um 23:51 schrieb Tobias Geerinckx-Rice:
>> Ludo:
>>> You forgot to push the patch. Could you add it?
>>
>> I've reverted this patch for now to keep master relatively happy.
>>
> Ups, soory. New package including the patch in
> 77e0cebcadc8b96613832e1554e326d48e20f72f
Thank you!
Another thing: could you add a couple of lines at the top of the patch
stating what the patch does and what its upstream status is? (For
example you can add a link to the upstream commit it comes from, if
applicable.)
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 06/06: gnu: Add weasyprint.
2019-10-23 14:24 ` Ludovic Courtès
@ 2019-10-28 8:37 ` Hartmut Goebel
0 siblings, 0 replies; 5+ messages in thread
From: Hartmut Goebel @ 2019-10-28 8:37 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
Am 23.10.19 um 16:24 schrieb Ludovic Courtès:
>
> Another thing: could you add a couple of lines at the top of the patch
Done: e30808ddb33f4aa0c4940ce8596ddc71ff55ed2a
Thanks for the review.
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-28 8:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191022150136.21331.97104@vcs0.savannah.gnu.org>
[not found] ` <20191022150138.819B2209DE@vcs0.savannah.gnu.org>
2019-10-22 20:13 ` 06/06: gnu: Add weasyprint Ludovic Courtès
2019-10-22 21:51 ` Tobias Geerinckx-Rice
2019-10-23 8:07 ` Hartmut Goebel
2019-10-23 14:24 ` Ludovic Courtès
2019-10-28 8:37 ` Hartmut Goebel
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).