* Re: 04/36: gnu: guix: Do not copy bootstrap-guile when cross-compiling.
[not found] ` <20200424121406.14E8220D9C@vcs0.savannah.gnu.org>
@ 2020-04-26 16:04 ` Ludovic Courtès
2020-04-26 19:09 ` Jan Nieuwenhuizen
0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2020-04-26 16:04 UTC (permalink / raw)
To: guix-devel
Hi!
guix-commits@gnu.org skribis:
> commit f1bf6c5d7dfae3c1fc28e417c2f0940b0b010087
> Author: Jan (janneke) Nieuwenhuizen <janneke@gnu.org>
> AuthorDate: Fri Apr 24 08:54:43 2020 +0200
>
> gnu: guix: Do not copy bootstrap-guile when cross-compiling.
>
> * gnu/packages/package-management.scm (guix)[arguments]: When cross-compiling,
> skip copy-bootstrap-guile phase; needed for tests only.
[...]
> - (add-before 'check 'copy-bootstrap-guile
> + ,@(if (%current-target-system)
> + '()
> + `((add-before 'check 'copy-bootstrap-guile
> (lambda* (#:key system inputs #:allow-other-keys)
Perhaps it would be clearer by avoiding the unquote-splicing dance:
(lambda* (#:key system target inputs #:allow-other-keys)
(unless target
…)
#t)
Otherwise LGTM!
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: 04/36: gnu: guix: Do not copy bootstrap-guile when cross-compiling.
2020-04-26 16:04 ` 04/36: gnu: guix: Do not copy bootstrap-guile when cross-compiling Ludovic Courtès
@ 2020-04-26 19:09 ` Jan Nieuwenhuizen
0 siblings, 0 replies; 2+ messages in thread
From: Jan Nieuwenhuizen @ 2020-04-26 19:09 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
Ludovic Courtès writes:
>> gnu: guix: Do not copy bootstrap-guile when cross-compiling.
>>
>> * gnu/packages/package-management.scm (guix)[arguments]: When cross-compiling,
>> skip copy-bootstrap-guile phase; needed for tests only.
...
>> - (add-before 'check 'copy-bootstrap-guile
>> + ,@(if (%current-target-system)
>> + '()
>> + `((add-before 'check 'copy-bootstrap-guile
>> (lambda* (#:key system inputs #:allow-other-keys)
>
> Perhaps it would be clearer by avoiding the unquote-splicing dance:
>
> (lambda* (#:key system target inputs #:allow-other-keys)
> (unless target
> …)
> #t)
Ah, yes. No need to be careful not to trigger a rebuild.
> Otherwise LGTM!
Thanks, pushed to core-updates.
janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-26 19:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200424121351.29896.37425@vcs0.savannah.gnu.org>
[not found] ` <20200424121406.14E8220D9C@vcs0.savannah.gnu.org>
2020-04-26 16:04 ` 04/36: gnu: guix: Do not copy bootstrap-guile when cross-compiling Ludovic Courtès
2020-04-26 19:09 ` Jan Nieuwenhuizen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).