Re: use zsh as login shell

[宋文武 <iyzsong@gmail.com>]

Ludovic Courtès <ludo@gnu.org> writes:

> 宋文武 <iyzsong@gmail.com> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> 宋文武 <iyzsong@gmail.com> skribis:
>
> [...]
>
>>>>>   3. The skeleton for ~/.bash_profile sources /etc/profile, /etc/bashrc,
>>>>>      and ~/.bashrc.
>>>>>
>>>>>   4. The definition of PS1 is moved from /etc/profile to /etc/bashrc.
>>>>>
>>>>>   5. The skeleton for ~/.bashrc sources /etc/bashrc.
>>>> It seem too much, what I suggested is:
>>>>     for login, su (pam_env): /etc/environment
>>>>     for login shell:         ~/.bash_profile, ~/.zlogin
>>>>     for interactive:         ~/.bashrc, ~/.zshrc
>>>> skeletons only installed when needed :)
>>>
>>> As a first step, what about always installing the skeletons?  Then we
>>> can see whether/how to refine that.
>
> [...]
>
>> From 1e400957b29a47f63548df39b36a7c0f1d8a37d9 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@gmail.com>
>> Date: Tue, 2 Dec 2014 21:40:52 +0800
>> Subject: [PATCH] gnu: Add /etc/environment.
>>
>> * gnu/system.scm (default-/etc/environment): New procedure.
>>   (etc-directory)[profile]: Remove it.
>>   (etc-directory)[environment]: Add it.
>> * gnu/system/linux.scm (unix-pam-service): Add #:readenv? parameter.
>> * gnu/services/base.scm (mingetty-service): Pass #t as #:readenv?
>>   to unix-pam-service.
>> * gnu/system/shadow.scm (default-skeletons): Add .bash_profile. Adjust .bashrc.
>
> So you ended up choosing pam_env?  I thought we had concluded that it
> wasn’t needed, no?  If it can be avoided, it’s better to do so, IMO.
Ok, I'll take this approach this weekend :)
>
>> +  (mlet %store-monad ((bash-profile (text-file "bash_profile" "\
>> +# honor ~/.bashrc if the shell is interactive
>> +[[ $- == *i* ]] && source ~/.bashrc
>
> I don’t think the test is needed, because ~/.bash_profile is only read
> by interactive Bash.
Yes, I'll do what Mark H Weaver suggest.
>
>> +# load system-wide environment varibales
>> +source /etc/environment
>> +
>> +# common varibales for user profile
>> +export PATH=$HOME/.guix-profile/bin:$HOME/.guix-profile/sbin:$PATH
>> +export INFOPATH=$HOME/.guix-profile/share/info:$INFOPATH\n"))
>> +                      (bashrc (text-file "bashrc" "\
>> +PS1='\\u@\\h \\w\\$ '
>
> I think PS1 should go to /etc/profile.  WDYT?
+1 for Mark.
>
> Thanks!
>
> Ludo’.