[PATCH] ncmpcpp version update, mail.scm copyright line

[PATCH] ncmpcpp version update, mail.scm copyright line

[Paul van der Walt]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

Hello again,

Included are 2 patches: one to update the copyright line in mail.scm,
since i forgot that when bumping the mu version, and another to upgrade
ncmpcpp, the MPD client, to latest stable.

Another question for you all: i would like to package MPC, the MPD cli
client, but mpc is already the name of the GNU multiprecision
library. What should i call this mpc package? Since i know that Guixers
are prone to long debates about names (i jest :p), here's my single
suggestion:

* mpc-client

Bye!
p.


[-- Attachment #2: 0001-gnu-mail-Add-copyright-line.patch --]
[-- Type: text/x-diff, Size: 830 bytes --]

From 0963038a01ff1b3c1646d58a2eae0f92180cb8f7 Mon Sep 17 00:00:00 2001
From: Paul van der Walt <paul@denknerd.org>
Date: Sat, 28 Feb 2015 14:28:00 +0100
Subject: [PATCH 1/2] gnu: mail: Add copyright line.

* gnu/packages/mail.scm (mu): Add forgotten copyright line.
---
 gnu/packages/mail.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index ca25c58..a3ea778 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2014 Sou Bunnbu <iyzsong@gmail.com>
 ;;; Copyright © 2014 Julien Lepiller <julien@lepiller.eu>
 ;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
+;;; Copyright © 2015 Paul van der Walt <paul@denknerd.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
-- 
2.3.1


[-- Attachment #3: 0002-gnu-ncmpcpp-Update-to-v0.6.2.patch --]
[-- Type: text/x-diff, Size: 2992 bytes --]

From 7666c884f2a06a4389e4889ab50429c4b1119422 Mon Sep 17 00:00:00 2001
From: Paul van der Walt <paul@denknerd.org>
Date: Sat, 28 Feb 2015 14:49:09 +0100
Subject: [PATCH 2/2] gnu: ncmpcpp: Update to v0.6.2

* gnu/packages/mpd.scm (ncmpcpp): Update to version 0.6.2. Added Boost,
  readline, autotools. Added copyright line.
---
 gnu/packages/mpd.scm | 26 +++++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index a1b4272..550e75d 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2014 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2014 Cyrill Schenkel <cyrill.schenkel@gmail.com>
 ;;; Copyright © 2014 Ian Denhardt <ian@zenhack.net>
+;;; Copyright © 2015 Paul van der Walt <paul@denknerd.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -27,6 +28,8 @@
   #:use-module (guix utils)
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages avahi)
+  #:use-module (gnu packages boost)
+  #:use-module (gnu packages readline)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages doxygen)
@@ -35,6 +38,7 @@
   #:use-module (gnu packages mp3)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages autotools)
   #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages databases)
   #:use-module (gnu packages video)
@@ -153,7 +157,7 @@ terminal using ncurses.")
 (define ncmpcpp
   (package
     (name "ncmpcpp")
-    (version "0.5.10")
+    (version "0.6.2")
     (source (origin
               (method url-fetch)
               (uri
@@ -161,11 +165,27 @@ terminal using ncurses.")
                               version ".tar.bz2"))
               (sha256
                (base32
-                "1a54g6dary1rirrny9fd0hpxpyyffypni3mpbdpvmjnrl9v56vgz"))))
+                "1mrd6m6ph0fscxp9x96ipxh6ai7w0n1miapcfqrqfy058qx5zbck"))))
     (build-system gnu-build-system)
     (inputs `(("libmpdclient" ,libmpdclient)
+              ("boost"  ,boost)
+              ("readline" ,readline)
               ("ncurses" ,ncurses)))
-    (native-inputs `(("pkg-config" ,pkg-config)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("automake" ,automake)
+       ("autoconf" ,autoconf)
+       ("libtool" ,libtool)))
+    (arguments
+     '(#:configure-flags
+       '("BOOST_LIB_SUFFIX=")
+       #:phases
+       (alist-cons-after
+        'unpack 'autogen
+        (lambda _
+          (setenv "NOCONFIGURE" "true")
+          (zero? (system* "sh" "autogen.sh")))
+        %standard-phases)))
     (synopsis "Featureful ncurses based MPD client inspired by ncmpc")
     (description "Ncmpcpp is an mpd client with a UI very similar to ncmpc,
 but it provides new useful features such as support for regular expressions
-- 
2.3.1

Re: [PATCH] ncmpcpp version update, mail.scm copyright line

[David Thompson]

Paul van der Walt <paul@denknerd.org> writes:

> Included are 2 patches: one to update the copyright line in mail.scm,
> since i forgot that when bumping the mu version, and another to upgrade
> ncmpcpp, the MPD client, to latest stable.

I've pushed these patches.  I modified your commit log to say "0.6.2"
instead of "v0.6.2", changed past tense verbs to present tense, and left
out the part about copyright.

> Another question for you all: i would like to package MPC, the MPD cli
> client, but mpc is already the name of the GNU multiprecision
> library. What should i call this mpc package? Since i know that Guixers
> are prone to long debates about names (i jest :p), here's my single
> suggestion:
>
> * mpc-client

Perhaps the GNU MPC package should be called "libmpc"?  Andreas,
thoughts?

In the meantime, don't let the naming issue stop you from packaging mpc.
We can figure that out at the end.

Thanks!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH] ncmpcpp version update, mail.scm copyright line

[Paul van der Walt]

On 2015-02-28 at 16:04, quoth David Thompson:
> I've pushed these patches.  I modified your commit log to say "0.6.2"
> instead of "v0.6.2", changed past tense verbs to present tense, and left
> out the part about copyright.

Thanks!

>> * mpc-client
>
> Perhaps the GNU MPC package should be called "libmpc"?  Andreas,
> thoughts?
>
> In the meantime, don't let the naming issue stop you from packaging mpc.
> We can figure that out at the end.

It's packaged, so when there's a name-decision, i'll send along a patch!

Cheers,
p.

Re: [PATCH] ncmpcpp version update, mail.scm copyright line

[David Thompson]

Paul van der Walt <paul@denknerd.org> writes:

> On 2015-02-28 at 16:04, quoth David Thompson:
>> In the meantime, don't let the naming issue stop you from packaging mpc.
>> We can figure that out at the end.
>
> It's packaged, so when there's a name-decision, i'll send along a patch!

Feel free to send the patch along now and we can get the rest of the
code review out of the way.  :)

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH] ncmpcpp version update, mail.scm copyright line

[Andreas Enge]

On Sat, Feb 28, 2015 at 10:04:26AM -0500, David Thompson wrote:
> Perhaps the GNU MPC package should be called "libmpc"?  Andreas,
> thoughts?

Oh no, I came first :-) Well, in Guix at least.

This is a complete clash, two projects with the exact same name. So we need
to make something up. I would suggest "mpd-mpc".

Andreas

Re: [PATCH] ncmpcpp version update, mail.scm copyright line

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> This is a complete clash, two projects with the exact same name. So we need
> to make something up. I would suggest "mpd-mpc".

+1

Ludo'.