[PATCH] gnu: Add gnome-backgrounds.

[PATCH] gnu: Add gnome-backgrounds.

[rennes]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

Hi,

i attached gnome-backgrounds patch for review.

Considerations:
  a) I can't find the licenses CC-BY2 and CC-BY-SA2 in licenses.scm.
  b) Just found the home-page 
"https://git.gnome.org/browse/gnome-backgrounds", for the project.


Thanks

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-gnome-backgrounds.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-gnome-backgrounds.patch, Size: 1889 bytes --]

From 80a921672022ddf1198c3d71c497d98f0800fe73 Mon Sep 17 00:00:00 2001
From: Rene Saavedra <rennes@openmailbox.org>
Date: Mon, 15 Feb 2016 12:18:28 -0600
Subject: [PATCH] gnu: Add gnome-backgrounds.

* gnu/packages/gnome.scm (gnome-backgrounds): New variable.

---
 gnu/packages/gnome.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index fd0ce67..76892cc 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -4681,3 +4681,30 @@ a specific user-requested directory branch (local or remote).  Once the scan
 is complete it provides a graphical representation of each selected folder.")
     (home-page "https://wiki.gnome.org/Apps/Baobab")
     (license license:gpl2+)))
+
+(define-public gnome-backgrounds
+  (package
+    (name "gnome-backgrounds")
+    (version "3.18.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://gnome/sources/" name "/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+       (base32
+        "1fd7y8dh3iy88ayb8irgsihvssli6bzjzb5a6vfhi8qjbw70ymma"))))
+    (build-system glib-or-gtk-build-system)
+    (native-inputs
+     `(("intltool" ,intltool)))
+    (home-page "https://git.gnome.org/browse/gnome-backgrounds")
+    (synopsis "Background images for the GNOME desktop")
+    (description
+     "GNOME backgrounds package contains a collection of graphics files
+which can be used as backgrounds in the GNOME Desktop environment.
+Additionally, the package creates the proper framework and directory structure
+so that you can add your own files to the collection.")
+    (license (list license:gpl2+
+                   ;; XXX: licensing also included: CC-BY2, CC-BY-SA2.
+                   license:cc-by-sa3.0))))
-- 
2.6.3

Re: [PATCH] gnu: Add gnome-backgrounds.

[Alex Kost]

rennes@openmailbox.org (2016-02-15 21:35 +0300) wrote:

> Hi,
>
> i attached gnome-backgrounds patch for review.
>
> Considerations:
>  a) I can't find the licenses CC-BY2 and CC-BY-SA2 in licenses.scm.

Then you are welcome to add them :-)  See commit 12abc6e¹ for example.

>  b) Just found the home-page
> "https://git.gnome.org/browse/gnome-backgrounds", for the project.

I think it's OK.  There is probably no special home for backgrounds.

[...]
> +(define-public gnome-backgrounds
> +  (package
> +    (name "gnome-backgrounds")
> +    (version "3.18.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://gnome/sources/" name "/"
> +                           (version-major+minor version) "/"
> +                           name "-" version ".tar.xz"))
> +       (sha256
> +       (base32
           (base32
          ↑↑
should be shifted a bit

> +        "1fd7y8dh3iy88ayb8irgsihvssli6bzjzb5a6vfhi8qjbw70ymma"))))
> +    (build-system glib-or-gtk-build-system)
> +    (native-inputs
> +     `(("intltool" ,intltool)))
> +    (home-page "https://git.gnome.org/browse/gnome-backgrounds")
> +    (synopsis "Background images for the GNOME desktop")
> +    (description
> +     "GNOME backgrounds package contains a collection of graphics files
> +which can be used as backgrounds in the GNOME Desktop environment.
> +Additionally, the package creates the proper framework and directory structure
> +so that you can add your own files to the collection.")
> +    (license (list license:gpl2+
> +                   ;; XXX: licensing also included: CC-BY2, CC-BY-SA2.
> +                   license:cc-by-sa3.0))))

Overall the patch looks good to me, so if you are willing to add these
missing licenses, I think we can commit 'gnome-backgrounds' afterwards.

¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=12abc6e39548a55c2b6ba4113f9f1bde8d5d08e1

-- 
Alex

Re: [PATCH] gnu: Add gnome-backgrounds.

[Alex Kost]

rennes@openmailbox.org (2016-02-15 21:35 +0300) wrote:

> From 80a921672022ddf1198c3d71c497d98f0800fe73 Mon Sep 17 00:00:00 2001
> From: Rene Saavedra <rennes@openmailbox.org>
> Date: Mon, 15 Feb 2016 12:18:28 -0600
> Subject: [PATCH] gnu: Add gnome-backgrounds.
[...]
> +    (license (list license:gpl2+
> +                   ;; XXX: licensing also included: CC-BY2, CC-BY-SA2.
> +                   license:cc-by-sa3.0))))

I've added these missing licenses (thanks again!) and pushed this patch.

-- 
Alex