From: ludo@gnu.org (Ludovic Courtès)
To: David Craven <david@craven.ch>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 2/2] system: Add btrfs file system support.
Date: Sat, 03 Dec 2016 16:18:43 +0100 [thread overview]
Message-ID: <87bmwtavn0.fsf@gnu.org> (raw)
In-Reply-To: <CAL1_imkQsEguFguwPRLnC-cGqe7zrxO0f923PwEdFxuUh9TJAQ@mail.gmail.com> (David Craven's message of "Fri, 2 Dec 2016 11:50:08 +0100")
David Craven <david@craven.ch> skribis:
> Then there is the label and uuid detection logic for every file-system
> that needs to be implemented. I'm wondering if it can be refactored, a
> quick late night and untested implementation for btrfs suggests that
> there is a lot of code repetition involved, I guess the same will be
> true for vfat. I'll have to check if there are any tests for this
> anywhere or write some before I mess with this "core piece" of guix.
This is covered by tests like “basic” and other lightweight tests: they
boot the system, so they get to exercise the file system label/UUID
lookup code (if the root partition is specified by a label/UUID at
least).
> Ludo: Is there any way we can speed up the installer system tests? :)
Most of the time is spent in building the latest Guix and running ‘guix
system init’. I don’t think this can be sped up.
The QEMU images involved are copied around, and maybe that part can be
slightly optimized. I did that in
130079ae27b47228516dc2934bcdecca5dbedf12.
Ludo’.
next prev parent reply other threads:[~2016-12-03 15:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 18:36 [PATCH 1/2] gnu: Add btrfs-progs/static David Craven
2016-11-30 18:36 ` [PATCH 2/2] system: Add btrfs file system support David Craven
2016-12-01 19:18 ` Marius Bakke
2016-12-02 10:50 ` David Craven
2016-12-02 11:12 ` Chris Marusich
2016-12-02 16:27 ` David Craven
2016-12-03 15:21 ` Ludovic Courtès
2016-12-03 15:18 ` Ludovic Courtès [this message]
2016-12-03 15:31 ` Ludovic Courtès
2016-12-03 16:21 ` David Craven
2016-12-05 20:44 ` Ludovic Courtès
2016-12-03 15:15 ` [PATCH 1/2] gnu: Add btrfs-progs/static Ludovic Courtès
2016-12-03 21:41 ` David Craven
2016-12-05 20:51 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmwtavn0.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).