From: ludo@gnu.org (Ludovic Courtès)
To: David Craven <david@craven.ch>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 2/2] system: Add btrfs file system support.
Date: Mon, 05 Dec 2016 21:44:37 +0100 [thread overview]
Message-ID: <8760my14y2.fsf@gnu.org> (raw)
In-Reply-To: <CAL1_imn4T2cZ1qM=iBrWV+gnNJE8eyKTs3hbUcS8fn2fCQ3nfg@mail.gmail.com> (David Craven's message of "Sat, 3 Dec 2016 17:21:13 +0100")
David Craven <david@craven.ch> skribis:
> The nice thing about having the check procedure be part of the
> <file-system> is that it can be overridden. I'm not sure what use
> cases there are yet. One I can think of is that btrfs device scan is
> only required when using a multi-device configuration like raid. So I
> don't know if we want to run it by default as a %btrfs-checker or do
> nothing by default, and let the user add a custom file system
> pre-mount hook (file-system-checker) when needed.
I don’t know enough about btrfs. Is it really useful in practice to
have a check procedure that is specific to the instance at hand?
For the other FS types, the check method really belongs in the FS type,
not in the FS instance. That is, all ext4 file systems are checked in
the same way. Thus, it doesn’t seem natural to store the fsck method in
the <file-system> object itself.
There’s also a practical issue with that: users would have to specify
the fsck method for every single <file-system> object:
(list (file-system
;; …
(type "ext4")
(fsck %ext4-fsck))
(file-system
;; …
(type "ext4")
(fsck %ext4-fsck)) ;again
(file-system
;; …
(type "ext4")
(fsck %ext4-fsck))) ;and again! :-)
> A version of Marius'es patch that works would be here:
> http://lists.gnu.org/archive/html/guix-devel/2016-12/msg00087.html
OK, this patch doesn’t have the problem above, but it’s kinda cheating.
:-)
I’ll reply separately!
Ludo’.
next prev parent reply other threads:[~2016-12-05 20:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 18:36 [PATCH 1/2] gnu: Add btrfs-progs/static David Craven
2016-11-30 18:36 ` [PATCH 2/2] system: Add btrfs file system support David Craven
2016-12-01 19:18 ` Marius Bakke
2016-12-02 10:50 ` David Craven
2016-12-02 11:12 ` Chris Marusich
2016-12-02 16:27 ` David Craven
2016-12-03 15:21 ` Ludovic Courtès
2016-12-03 15:18 ` Ludovic Courtès
2016-12-03 15:31 ` Ludovic Courtès
2016-12-03 16:21 ` David Craven
2016-12-05 20:44 ` Ludovic Courtès [this message]
2016-12-03 15:15 ` [PATCH 1/2] gnu: Add btrfs-progs/static Ludovic Courtès
2016-12-03 21:41 ` David Craven
2016-12-05 20:51 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760my14y2.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).