* Re: 01/03: build: file-systems: Add luks to %partition-uuid-readers.
[not found] ` <20181208013858.08BD120EA2@vcs0.savannah.gnu.org>
@ 2018-12-08 13:06 ` Ludovic Courtès
2018-12-08 14:42 ` Mathieu Othacehe
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2018-12-08 13:06 UTC (permalink / raw)
To: guix-devel, Mathieu Othacehe
Hello!
guix-commits@gnu.org skribis:
> commit fa358c557f130f393d8c7400ffa954f75112d09e
> Author: Mathieu Othacehe <m.othacehe@gmail.com>
> Date: Fri Dec 7 14:03:06 2018 +0900
>
> build: file-systems: Add luks to %partition-uuid-readers.
>
> * gnu/build/file-systems.scm (%partition-uuid-readers): Add luks reader.
Currently ‘find-partition-by-luks-uuid’ is separate from
‘find-partition-by-uuid’. This is because when looking for a LUKS
mapped device, we know we’re looking specifically for that and nothing
else (this is used in the implementation of ‘luks-device-mapping’);
likewise, when looking for a “real partition”, we know we’re not looking
for a LUKS mapped device.
Thus I think it’s probably best to keep LUKS UUID lookup separate from
file system lookup.
WDYT? Are there use cases in the installer where this is problematic?
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 02/03: installer: partionment: Add encryption support.
[not found] ` <20181208013858.38B3820E87@vcs0.savannah.gnu.org>
@ 2018-12-08 13:10 ` Ludovic Courtès
2018-12-08 14:47 ` Mathieu Othacehe
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2018-12-08 13:10 UTC (permalink / raw)
To: guix-devel, Mathieu Othacehe
Hi again! :-)
guix-commits@gnu.org skribis:
> commit 14826f39e3965ddc09c0e7e6e29654e832395af4
> Author: Mathieu Othacehe <m.othacehe@gmail.com>
> Date: Fri Dec 7 14:04:25 2018 +0900
>
> installer: partionment: Add encryption support.
>
> * gnu/installer.scm (set-installer-path): Add cryptsetup.
> * gnu/installer/newt/partition.scm (prompt-luks-passwords): New procedure,
> (run-partioning-page): Add the possibility to set encryption to "On" on a
> partition and choose a label, add a new partition scheme: "Guided - using the
> entire disk with encryption", prompt for encryption passwords before
> proceeding to formating.
> * gnu/installer/parted.scm (<user-partition>)[crypt-label],
> [crypt-password]: New fields,
> (partition-description): add the encryption label,
> (user-partition-description): add an encryption field,
> (auto-partition): add two partitioning schemes: entire-crypted-root and
> entire-crypted-root-home,
> (call-with-luks-key-file): new procedure,
> (user-partition-upper-path): new procedure,
> (luks-format-and-open): new procedure,
> (luks-close): new procedure,
> (format-user-partitions): format and open luks partitions before creating
> file-system.
> (mount-user-partitions): use the path returned by user-partition-upper-path,
> (umount-user-partitions): close the luks partitions,
> (user-partition->file-system): set device field to label for luks partitions
> and to uuid for the rest,
> (user-partition->mapped-device): new procedure,
> (user-partitions->configuration): add mapped-devices field.
Woow, really cool!
Nitpicking on words: s/partitionment/partitioning/,
s/crypted/encrypted/, s/path/file name/ (this one is just a GNU
convention.)
Really awesome to have a UI to deal with this. I didn’t expect it to
land this quickly, thumbs up!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 01/03: build: file-systems: Add luks to %partition-uuid-readers.
2018-12-08 13:06 ` 01/03: build: file-systems: Add luks to %partition-uuid-readers Ludovic Courtès
@ 2018-12-08 14:42 ` Mathieu Othacehe
2018-12-08 23:20 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Mathieu Othacehe @ 2018-12-08 14:42 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
Hey Ludo!
> Thus I think it’s probably best to keep LUKS UUID lookup separate from
> file system lookup.
>
> WDYT? Are there use cases in the installer where this is problematic?
It makes sense and there are no particular need, so I reverted this
commit and replaced it by 488a0a8d6120ead3499ba7742c5d630ddf936476 which
exports a new read-luks-partition-uuid procedure.
What do you think of this new approach?
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 02/03: installer: partionment: Add encryption support.
2018-12-08 13:10 ` 02/03: installer: partionment: Add encryption support Ludovic Courtès
@ 2018-12-08 14:47 ` Mathieu Othacehe
0 siblings, 0 replies; 5+ messages in thread
From: Mathieu Othacehe @ 2018-12-08 14:47 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
Hey!
> Woow, really cool!
Thanks for all the kind words ;)
> Nitpicking on words: s/partitionment/partitioning/,
> s/crypted/encrypted/, s/path/file name/ (this one is just a GNU
> convention.)
Ok I'll do a massive renaming.
>
> Really awesome to have a UI to deal with this. I didn’t expect it to
> land this quickly, thumbs up!
Best to strike while the iron is hot! However, this encryption part is
still not completely stable, in particular during umounting/closing. I
sent a mail earlier today about that.
I also plan to add a new partitioning scheme: "Use the largest
continuous free space". This way, we will have the same partitioning
schemes as debian installer (which I find quite handy).
Thanks for the feedback!
Mathieu
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 01/03: build: file-systems: Add luks to %partition-uuid-readers.
2018-12-08 14:42 ` Mathieu Othacehe
@ 2018-12-08 23:20 ` Ludovic Courtès
0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2018-12-08 23:20 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: guix-devel
Hello Mathieu!
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
>> Thus I think it’s probably best to keep LUKS UUID lookup separate from
>> file system lookup.
>>
>> WDYT? Are there use cases in the installer where this is problematic?
>
> It makes sense and there are no particular need, so I reverted this
> commit and replaced it by 488a0a8d6120ead3499ba7742c5d630ddf936476 which
> exports a new read-luks-partition-uuid procedure.
>
> What do you think of this new approach?
It LGTM. Thank you!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-12-08 23:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20181208013857.21870.57588@vcs0.savannah.gnu.org>
[not found] ` <20181208013858.08BD120EA2@vcs0.savannah.gnu.org>
2018-12-08 13:06 ` 01/03: build: file-systems: Add luks to %partition-uuid-readers Ludovic Courtès
2018-12-08 14:42 ` Mathieu Othacehe
2018-12-08 23:20 ` Ludovic Courtès
[not found] ` <20181208013858.38B3820E87@vcs0.savannah.gnu.org>
2018-12-08 13:10 ` 02/03: installer: partionment: Add encryption support Ludovic Courtès
2018-12-08 14:47 ` Mathieu Othacehe
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).