unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Typo in comment guix/ui.scm ?
@ 2020-02-09 10:19 Vincent Legoll
  2020-02-10  7:50 ` zimoun
  0 siblings, 1 reply; 4+ messages in thread
From: Vincent Legoll @ 2020-02-09 10:19 UTC (permalink / raw)
  To: guix-devel

Hello,

While reading recent commits, I saw a comment
addition that looks strange.

I cannot understand the "come" line 774 in guix/ui.scm
added by:
a07d5e558b5403dad0a59776b950b6b02169c249

Thanks

-- 
Vincent Legoll

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Typo in comment guix/ui.scm ?
  2020-02-09 10:19 Typo in comment guix/ui.scm ? Vincent Legoll
@ 2020-02-10  7:50 ` zimoun
  2020-02-10  9:30   ` Vincent Legoll
  0 siblings, 1 reply; 4+ messages in thread
From: zimoun @ 2020-02-10  7:50 UTC (permalink / raw)
  To: Vincent Legoll; +Cc: guix-devel

Dear,

On Sun, 9 Feb 2020 at 15:33, Vincent Legoll <vincent.legoll@gmail.com> wrote:

> I cannot understand the "come" line 774 in guix/ui.scm
> added by:
> a07d5e558b5403dad0a59776b950b6b02169c249

You are proposing to remove the word 'come' in the comment, right?


All the best,
simon

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Typo in comment guix/ui.scm ?
  2020-02-10  7:50 ` zimoun
@ 2020-02-10  9:30   ` Vincent Legoll
  2020-02-11 14:44     ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Vincent Legoll @ 2020-02-10  9:30 UTC (permalink / raw)
  To: zimoun; +Cc: guix-devel

Hello

On Mon, Feb 10, 2020 at 8:50 AM zimoun <zimon.toutoune@gmail.com> wrote:
> On Sun, 9 Feb 2020 at 15:33, Vincent Legoll <vincent.legoll@gmail.com> wrote:
>
> > I cannot understand the "come" line 774 in guix/ui.scm
> > added by:
> > a07d5e558b5403dad0a59776b950b6b02169c249
>
> You are proposing to remove the word 'come' in the comment, right?

I'm not sure, not a native English speaker, but that would look better, yes.

I hope Ludovic will chime in with his intended purpose...

-- 
Vincent Legoll

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Typo in comment guix/ui.scm ?
  2020-02-10  9:30   ` Vincent Legoll
@ 2020-02-11 14:44     ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2020-02-11 14:44 UTC (permalink / raw)
  To: Vincent Legoll; +Cc: guix-devel

Hi,

Vincent Legoll <vincent.legoll@gmail.com> skribis:

> On Mon, Feb 10, 2020 at 8:50 AM zimoun <zimon.toutoune@gmail.com> wrote:
>> On Sun, 9 Feb 2020 at 15:33, Vincent Legoll <vincent.legoll@gmail.com> wrote:
>>
>> > I cannot understand the "come" line 774 in guix/ui.scm
>> > added by:
>> > a07d5e558b5403dad0a59776b950b6b02169c249
>>
>> You are proposing to remove the word 'come' in the comment, right?
>
> I'm not sure, not a native English speaker, but that would look better, yes.
>
> I hope Ludovic will chime in with his intended purpose...

Oops, it’s a typo, I’ll push a fix shortly.

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-02-11 14:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-09 10:19 Typo in comment guix/ui.scm ? Vincent Legoll
2020-02-10  7:50 ` zimoun
2020-02-10  9:30   ` Vincent Legoll
2020-02-11 14:44     ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).