Re: [workflow] Automatically close bug report when a patch is committed

[Simon Tournier <zimon.toutoune@gmail.com>]

Hi Maxim,

On Sat, 09 Sep 2023 at 19:50, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

>>> --8<---------------cut here---------------start------------->8---
>>> random=$({ git var GIT_COMMITTER_IDENT ; echo "$refhash" ; cat "$1"; } |
>>>   git hash-object --stdin)
>>> --8<---------------cut here---------------end--------------->8---
>>
>> That seems like it would only work if the patch was identical, as
>> opposed to a slightly rebased patch on top of newer patches on master?
>>
>> How can you correlate Change-Id to a patch in the tracker?
>
> The Change-Id stays the same unless you manually edit it out of your
> commit message when amending / rebasing, so the commit hash may change
> while the Change-Id stays the same.  So you can rebase your feature
> branch on master and share a v2, whose existing commits will have the
> same Change-Ids (newly added commits would get their own Change-Id
> trailer).

I am sorry if I am slow but I do not understand.

--8<---------------cut here---------------start------------->8---
$ git var GIT_COMMITTER_IDENT
Simon Tournier <zimon.toutoune@gmail.com> 1694428674 +0200
$ git var GIT_COMMITTER_IDENT
Simon Tournier <zimon.toutoune@gmail.com> 1694428800 +0200
--8<---------------cut here---------------end--------------->8---

Therefore this Change-Id can be different for the same series, depending
when I am locally committing.  No?

And sorry if I am slow but I am also missing your answer about “How can
you correlate Change-Id to a patch in the tracker?”.  How is this
Change-Id correlated to the Debbugs number?


Let take an example. :-) Assume Change-Id was used for your submission
bug#65280 about Qt.  It reads many patches and we have:

        02/59
        1717c8a233b7fda3a10aabc061168c71317f883e
        AuthorDate: Fri Aug 11 15:26:14 2023 -0400

        59/59
        0a77b869322274030c4c0e8315ddea802da44c92
        AuthorDate: Tue Aug 15 16:20:10 2023 -0400

From my understanding,

 1. GIT_COMMITTER_IDENT depends on time so these two commits would have
a different Change-Id, no?

 2. How is Change-Id linked to #65280?

Cheers,
simon