Re: [PATCH] Add patchutils and quilt

[ludo@gnu.org (Ludovic Courtès)]

Eric Bavier <ericbavier@gmail.com> skribis:

> From df0c351c53ede204d4b60bad0c0709fec0708675 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Mon, 7 Apr 2014 11:15:48 -0500
> Subject: [PATCH] gnu: Add patchutils and quilt
>
> * gnu/packages/patchutils.scm: New file
> * gnu/packages/patches/patchutils-xfail-gendiff-tests.patch: New patch
> * gnu-system.am (GNU_SYSTEM_MODULES): Add patchutils.
>   (dist_patch_DATA): Add patch.

[...]

> +    (inputs `(("perl" ,perl)
> +              ("diffutils" ,diffutils)
> +              ("patch" ,patch)
> +              ("sed" ,sed)
> +              ("gawk" ,gawk)))

Only Perl needs to be kept; the others are implicitly provided.

If Perl is also needed at build time, it should be added to
‘native-inputs’.

> +    (synopsis "Collection of tools for manupulating patch files")
> +    (description
> +     "Patchutils contains a collection of tools for manipulating patch files:
> +interdiff, combinediff, flipdiff, filterdiff, fixcvsdiff, rediff, lsdiff,
> +grepdiff, splitdiff, recountdiff, and unwrapdiff. You can use interdiff to
> +create an incremental patch between two patches that are against a common
> +source tree, combinediff for creating a cumulative diff from two incremental
> +patches, and flipdiff to transpose two incremental patches. Filterdiff is for
> +extracting or excluding patches from a patch set based on modified files
> +matching shell wildcards. Lsdiff lists modified files in a patch. Rediff,
> +recountdiff, and unwrapdiff correct hand-edited (or otherwise broken)
> +patches.")

It would be perfect if you could shorten that to 6-7 lines, and add two
spaces after end-of-sentence periods.

> +    (inputs `(("perl" ,perl)
> +              ("diffutils" ,diffutils)
> +              ("findutils" ,findutils)
> +              ("less" ,less)
> +              ("file" ,file)
> +              ("ed" ,ed)
> +              ("sed" ,sed)
> +              ("bash" ,bash)
> +              ("grep" ,grep)))

Likewise: only Perl, less, file, and ed must be kept.

Could you change that before pushing?

Thanks,
Ludo’.