From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add patchutils and quilt
Date: Mon, 07 Apr 2014 21:10:44 +0200
Message-ID: <87a9bxuf9n.fsf@gnu.org>
References: <871tx98655.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44893)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WXEwX-0003kk-1F
	for guix-devel@gnu.org; Mon, 07 Apr 2014 15:10:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WXEwR-0007WU-Ko
	for guix-devel@gnu.org; Mon, 07 Apr 2014 15:10:52 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:51786)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1WXEwR-0007Vf-AU
	for guix-devel@gnu.org; Mon, 07 Apr 2014 15:10:47 -0400
In-Reply-To: <871tx98655.fsf@gmail.com> (Eric Bavier's message of "Mon, 07 Apr
	2014 11:18:46 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org

Eric Bavier <ericbavier@gmail.com> skribis:

> From df0c351c53ede204d4b60bad0c0709fec0708675 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Mon, 7 Apr 2014 11:15:48 -0500
> Subject: [PATCH] gnu: Add patchutils and quilt
>
> * gnu/packages/patchutils.scm: New file
> * gnu/packages/patches/patchutils-xfail-gendiff-tests.patch: New patch
> * gnu-system.am (GNU_SYSTEM_MODULES): Add patchutils.
>   (dist_patch_DATA): Add patch.

[...]

> +    (inputs `(("perl" ,perl)
> +              ("diffutils" ,diffutils)
> +              ("patch" ,patch)
> +              ("sed" ,sed)
> +              ("gawk" ,gawk)))

Only Perl needs to be kept; the others are implicitly provided.

If Perl is also needed at build time, it should be added to
=E2=80=98native-inputs=E2=80=99.

> +    (synopsis "Collection of tools for manupulating patch files")
> +    (description
> +     "Patchutils contains a collection of tools for manipulating patch f=
iles:
> +interdiff, combinediff, flipdiff, filterdiff, fixcvsdiff, rediff, lsdiff,
> +grepdiff, splitdiff, recountdiff, and unwrapdiff. You can use interdiff =
to
> +create an incremental patch between two patches that are against a common
> +source tree, combinediff for creating a cumulative diff from two increme=
ntal
> +patches, and flipdiff to transpose two incremental patches. Filterdiff i=
s for
> +extracting or excluding patches from a patch set based on modified files
> +matching shell wildcards. Lsdiff lists modified files in a patch. Rediff,
> +recountdiff, and unwrapdiff correct hand-edited (or otherwise broken)
> +patches.")

It would be perfect if you could shorten that to 6-7 lines, and add two
spaces after end-of-sentence periods.

> +    (inputs `(("perl" ,perl)
> +              ("diffutils" ,diffutils)
> +              ("findutils" ,findutils)
> +              ("less" ,less)
> +              ("file" ,file)
> +              ("ed" ,ed)
> +              ("sed" ,sed)
> +              ("bash" ,bash)
> +              ("grep" ,grep)))

Likewise: only Perl, less, file, and ed must be kept.

Could you change that before pushing?

Thanks,
Ludo=E2=80=99.