From: ludo@gnu.org (Ludovic Courtès)
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel <Guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: cross-base: Disable libcilkrts in cross-gcc.
Date: Sun, 19 Jul 2015 23:16:31 +0200 [thread overview]
Message-ID: <87a8urkfv4.fsf@gnu.org> (raw)
In-Reply-To: <CAFtzXzM_z=qdb-qdg3LYi8COrA0XF2mOxhDkqf7g9PYDt=zg=g@mail.gmail.com> (Manolis Ragkousis's message of "Sun, 19 Jul 2015 18:28:21 +0300")
Manolis Ragkousis <manolis837@gmail.com> skribis:
> From 37d96c984baeb4e2857d8338fae3e9459140e8f5 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Sun, 19 Jul 2015 18:16:51 +0300
> Subject: [PATCH] gnu: cross-base: Disable libcilkrts in cross-gcc.
>
> * gnu/packages/cross-base.scm (cross-gcc-arguments): Add "--disable-libcilkrts".
We'll keep it out of master until after 0.8.3 if you don’t mind.
> + `( ;; Disable libcilkrts because it causes the
> + ;; build to fail when targeting the Hurd.
> + "--disable-libcilkrts")
The comment should be more specific: it should make it clear that
libcilkrts is not ported to GNU/Hurd (“causes the build to fail” sounds
like “something went wrong but we didn’t bother”, which is not the case
here!).
Ideally we’d disable it for GNU/Hurd targets only, but OTOH, I think we
can safely assume that nobody will notice that Cilk support is missing...
Ludo’.
next prev parent reply other threads:[~2015-07-19 21:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-19 15:28 [PATCH] gnu: cross-base: Disable libcilkrts in cross-gcc Manolis Ragkousis
2015-07-19 21:16 ` Ludovic Courtès [this message]
2015-07-21 10:07 ` Manolis Ragkousis
2015-07-24 20:52 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8urkfv4.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=Guix-devel@gnu.org \
--cc=manolis837@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).