From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: cross-base: Disable libcilkrts in cross-gcc.
Date: Sun, 19 Jul 2015 23:16:31 +0200
Message-ID: <87a8urkfv4.fsf@gnu.org>
References: <CAFtzXzM_z=qdb-qdg3LYi8COrA0XF2mOxhDkqf7g9PYDt=zg=g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55312)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZGvwr-0003JV-9z
	for Guix-devel@gnu.org; Sun, 19 Jul 2015 17:16:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZGvwo-0003Hj-5G
	for Guix-devel@gnu.org; Sun, 19 Jul 2015 17:16:37 -0400
In-Reply-To: <CAFtzXzM_z=qdb-qdg3LYi8COrA0XF2mOxhDkqf7g9PYDt=zg=g@mail.gmail.com>
	(Manolis Ragkousis's message of "Sun, 19 Jul 2015 18:28:21 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel <Guix-devel@gnu.org>

Manolis Ragkousis <manolis837@gmail.com> skribis:

> From 37d96c984baeb4e2857d8338fae3e9459140e8f5 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Sun, 19 Jul 2015 18:16:51 +0300
> Subject: [PATCH] gnu: cross-base: Disable libcilkrts in cross-gcc.
>
> * gnu/packages/cross-base.scm (cross-gcc-arguments): Add "--disable-libci=
lkrts".

We'll keep it out of master until after 0.8.3 if you don=E2=80=99t mind.

> +                             `( ;; Disable libcilkrts because it causes =
the
> +                                ;; build to fail when targeting the Hurd.
> +                               "--disable-libcilkrts")

The comment should be more specific: it should make it clear that
libcilkrts is not ported to GNU/Hurd (=E2=80=9Ccauses the build to fail=E2=
=80=9D sounds
like =E2=80=9Csomething went wrong but we didn=E2=80=99t bother=E2=80=9D, w=
hich is not the case
here!).

Ideally we=E2=80=99d disable it for GNU/Hurd targets only, but OTOH, I thin=
k we
can safely assume that nobody will notice that Cilk support is missing...

Ludo=E2=80=99.