unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] gnu: dwm: Shorten the description.
@ 2016-08-07 12:02 ng0
  2016-08-07 14:06 ` Alex Kost
  2016-08-11 15:15 ` Alex Kost
  0 siblings, 2 replies; 4+ messages in thread
From: ng0 @ 2016-08-07 12:02 UTC (permalink / raw)
  To: guix-devel


[-- Attachment #1.1: Type: text/plain, Size: 205 bytes --]

This description was as long as the package itself.  We should not do
this, this is enough. Whoever wants to read up on dwm and tiling wm in
general can read about it in dwm documentation and other twms.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-dwm-Shorten-the-description.patch --]
[-- Type: text/x-patch, Size: 2287 bytes --]

From 998375b857e807b76144571b4290610ca3e99b96 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@we.make.ritual.n0.is>
Date: Sun, 7 Aug 2016 11:59:42 +0000
Subject: [PATCH] gnu: dwm: Shorten the description.

* gnu/packages/suckless.scm (dwm)[description]: Shorten it.
---
 gnu/packages/suckless.scm | 25 +------------------------
 1 file changed, 1 insertion(+), 24 deletions(-)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 87e5aad..8732a84 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -68,30 +68,7 @@
     (description
      "dwm is a dynamic window manager for X.  It manages windows in tiled,
 monocle and floating layouts.  All of the layouts can be applied dynamically,
-optimising the environment for the application in use and the task performed.
-
-In tiled layout windows are managed in a master and stacking area.  The master
-area contains the window which currently needs most attention, whereas the
-stacking area contains all other windows.  In monocle layout all windows are
-maximised to the screen size.  In floating layout windows can be resized and
-moved freely.  Dialog windows are always managed floating, regardless of the
-layout applied.
-
-Windows are grouped by tags.  Each window can be tagged with one or multiple
-tags.  Selecting certain tags displays all windows with these tags.
-
-Each screen contains a small status bar which displays all available tags, the
-layout, the number of visible windows, the title of the focused window, and the
-text read from the root window name property, if the screen is focused.  A
-floating window is indicated with an empty square and a maximised floating
-window is indicated with a filled square before the windows title.  The selected
-tags are indicated with a different color.  The tags of the focused window are
-indicated with a filled square in the top left corner.  The tags which are
-applied to one or more windows are indicated with an empty square in the top
-left corner.
-
-dwm draws a small customizable border around windows to indicate the focus
-state.")
+optimising the environment for the application in use and the task performed.")
     (license license:x11)))
 
 (define-public dmenu
-- 
2.9.2


[-- Attachment #1.3: Type: text/plain, Size: 134 bytes --]


-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] gnu: dwm: Shorten the description.
  2016-08-07 12:02 [PATCH] gnu: dwm: Shorten the description ng0
@ 2016-08-07 14:06 ` Alex Kost
  2016-08-07 15:02   ` ng0
  2016-08-11 15:15 ` Alex Kost
  1 sibling, 1 reply; 4+ messages in thread
From: Alex Kost @ 2016-08-07 14:06 UTC (permalink / raw)
  To: ng0; +Cc: guix-devel

ng0 (2016-08-07 15:02 +0300) wrote:

> This description was as long as the package itself.  We should not do
> this, this is enough. Whoever wants to read up on dwm and tiling wm in
> general can read about it in dwm documentation and other twms.

I agree, so if there are no objections, I'm going to commit it.

ng0, IIUC you don't have commit access to the guix git repo, right?
Ludovic is on vacations, but if you are willing to have it, I think the
other project admins wouldn't mind to add you to the Guix group
<https://savannah.gnu.org/projects/guix/>.

-- 
Alex

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gnu: dwm: Shorten the description.
  2016-08-07 14:06 ` Alex Kost
@ 2016-08-07 15:02   ` ng0
  0 siblings, 0 replies; 4+ messages in thread
From: ng0 @ 2016-08-07 15:02 UTC (permalink / raw)
  To: Alex Kost; +Cc: guix-devel

Hi,

Alex Kost <alezost@gmail.com> writes:

> ng0 (2016-08-07 15:02 +0300) wrote:
>
>> This description was as long as the package itself.  We should not do
>> this, this is enough. Whoever wants to read up on dwm and tiling wm in
>> general can read about it in dwm documentation and other twms.
>
> I agree, so if there are no objections, I'm going to commit it.
>
> ng0, IIUC you don't have commit access to the guix git repo, right?
> Ludovic is on vacations, but if you are willing to have it, I think the
> other project admins wouldn't mind to add you to the Guix group
> <https://savannah.gnu.org/projects/guix/>.
>
> -- 
> Alex

Thanks Alex.

I had an exchange of messages with Ludovic, where some of the people
with commit access were also CC'd and we (only Ludovic and myself) came
to agree that my work is good but some further mentoring is needed until
I can work completely on my own.

With that in mind, I'd like to have a feedback on what's there to
improve.
I can recall only recall some commit messages which were not completely
correct or otherwise not to the liking of the person who pushed them.

I'd prefer to have feedback first, and opinions of other people with
commit access as I value opinion over just giving access.

Grothoff over at GNUnet handles this differently than Ludovic it seems,
they prefer to give access to regular contributors and fix if a commit
breaks something (of course you shouldn't commit breakage in the first
place if you can avoid it), to take off the annoying task for commiting
trivial fixes in the names of other people. I guess that's why you ask
me, I start to commit so much that with still no review order/framework
in place commit access would make this easier. QA will still apply, but
commiting is also some minutes of work for the person who does it.
-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gnu: dwm: Shorten the description.
  2016-08-07 12:02 [PATCH] gnu: dwm: Shorten the description ng0
  2016-08-07 14:06 ` Alex Kost
@ 2016-08-11 15:15 ` Alex Kost
  1 sibling, 0 replies; 4+ messages in thread
From: Alex Kost @ 2016-08-11 15:15 UTC (permalink / raw)
  To: ng0; +Cc: guix-devel

ng0 (2016-08-07 15:02 +0300) wrote:

> This description was as long as the package itself.  We should not do
> this, this is enough. Whoever wants to read up on dwm and tiling wm in
> general can read about it in dwm documentation and other twms.
>
> From 998375b857e807b76144571b4290610ca3e99b96 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@we.make.ritual.n0.is>
> Date: Sun, 7 Aug 2016 11:59:42 +0000
> Subject: [PATCH] gnu: dwm: Shorten the description.
>
> * gnu/packages/suckless.scm (dwm)[description]: Shorten it.

Applied as dfde065.

-- 
Alex

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-08-11 15:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-07 12:02 [PATCH] gnu: dwm: Shorten the description ng0
2016-08-07 14:06 ` Alex Kost
2016-08-07 15:02   ` ng0
2016-08-11 15:15 ` Alex Kost

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).