From: Ricardo Wurmus <rekado@elephly.net>
To: Ben Woodcroft <donttrustben@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/4] gnu: Add ncbi-tools.
Date: Sat, 03 Dec 2016 20:19:33 +0100 [thread overview]
Message-ID: <87a8cces6y.fsf@elephly.net> (raw)
In-Reply-To: <20161203103901.27770-2-donttrustben@gmail.com>
Hi Ben,
thank you for the patch!
> * gnu/packages/bioinformatics.scm (ncbi-tools): New variable.
> ---
> gnu/packages/bioinformatics.scm | 62 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
[…]
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure)
> + (add-after 'unpack 'patch-sources
> + (lambda _
Indentation here is a little too far. The opening paren is usually
aligned with the first “d” off “add-after”.
> + (for-each (lambda (file)
> + (substitute* file
> + (("NCBI_MAKE_SHELL = .*")
> + (string-append
> + "NCBI_MAKE_SHELL = "
> + (which "sh")
> + "\n"))))
> + (find-files "platform" ".*mk"))
Here I’d use
(substitute* (find-files "platform" ".*mk")
…)
“substitute*” can take a list of files. That’s nicer than using
“for-each” here.
> + (substitute* "make/ln-if-absent"
> + (("set path=\\(/usr/bin /bin\\)") ""))
> + #t))
> + (replace 'build
> + (lambda _
Same as above; it’s a little too far to the right.
> + (chdir "..")
> + (zero? (system* "ncbi/make/makedis.csh"))))
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
And the same here.
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (string-append out "/bin"))
> + (man (string-append out "/share/man/man1")))
> + (for-each (lambda (file)
> + (install-file
> + (string-append "ncbi/build/" file) bin)
> + (install-file
> + (string-append "ncbi/doc/man/" file ".1") man))
> + ;; XXX: TODO: Install and test other binaries.
> + (list "tbl2asn"))
> + #t))))))
> + (native-inputs
> + `(("csh" ,tcsh)
> + ("pkg-config" ,pkg-config)
> + ("coreutils" ,coreutils)))
> + (home-page "https://www.ncbi.nlm.nih.gov/IEB/ToolBox/MainPage/index.html")
> + (synopsis "NCBI-related tools")
> + (description "The United States of America @dfn{National Center for
> +Biotechnology Information} (NCBI) Software Development Toolkit is for the
> +production and distribution of GenBank, Entrez, BLAST and related NCBI
> +services.")
> + (license license:public-domain)))
> +
Okay with these changes. Thank you!
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
http://elephly.net
next prev parent reply other threads:[~2016-12-03 19:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 10:38 [PATCH 1/4] gnu: Add perl-time-piece Ben Woodcroft
2016-12-03 10:38 ` [PATCH 2/4] gnu: Add ncbi-tools Ben Woodcroft
2016-12-03 19:19 ` Ricardo Wurmus [this message]
2016-12-03 19:30 ` Marius Bakke
2016-12-03 10:39 ` [PATCH 3/4] gnu: Add barrnap Ben Woodcroft
2016-12-03 19:20 ` Ricardo Wurmus
2016-12-03 19:36 ` Marius Bakke
2016-12-04 15:51 ` Ricardo Wurmus
2016-12-03 10:39 ` [PATCH 4/4] gnu: Add prokka Ben Woodcroft
2016-12-03 19:47 ` Marius Bakke
2016-12-03 18:55 ` [PATCH 1/4] gnu: Add perl-time-piece Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8cces6y.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=donttrustben@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).