asdf-build-system: Problem running tests for cl-unicode

asdf-build-system: Problem running tests for cl-unicode

[Ricardo Wurmus]

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

Hi,

I’m trying to build a package for sbcl-cl-unicode, which I need for a JS
uglifier (to be able to generate minified JS files in other packages’
build processes).

Unfortunately, the tests fail with

    "The name NIL does not designate any package."

“cl-unicode” seems to have more problems.  When I ignore the tests and
try to build “sbcl-cl-ppcre-unicode” (see below), I get an error about
“CL-UNICODE” not designating any package.

Here’s the definition of “sbcl-cl-ppcre-unicode”:

(define-public sbcl-cl-ppcre-unicode
  (package (inherit sbcl-cl-ppcre)
    (name "sbcl-cl-ppcre-unicode")
    (arguments
     `(#:asd-file "cl-ppcre-unicode.asd"))
    (inputs
     `(("sbcl-cl-ppcre" ,sbcl-cl-ppcre)
       ("sbcl-cl-unicode" ,sbcl-cl-unicode)))))

Attached is the patch for “sbcl-cl-unicode”.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-WIP-gnu-Add-sbcl-cl-unicode.patch --]
[-- Type: text/x-patch, Size: 1859 bytes --]

From 3633ecb568c6dc3ca46758796470f7154ccae70d Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado@elephly.net>
Date: Thu, 29 Dec 2016 17:26:40 +0100
Subject: [PATCH] WIP gnu: Add sbcl-cl-unicode.

* gnu/packages/lisp.scm (sbcl-cl-unicode): New variable.
---
 gnu/packages/lisp.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index ec0bdaaa5..35faa2459 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -702,6 +702,33 @@ compatible with ANSI-compliant Common Lisp implementations.")
 (define-public ecl-cl-ppcre
   (sbcl-package->ecl-package sbcl-cl-ppcre))
 
+(define-public sbcl-cl-unicode
+  (package
+    (name "sbcl-cl-unicode")
+    (version "0.1.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/edicl/cl-unicode/"
+                           "archive/v" version ".tar.gz"))
+       (file-name (string-append "cl-unicode-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1qvy6wfyvn0n4hscg75q4004q98h2k0gwf7n157ckhrka7d1v7wy"))))
+    (build-system asdf-build-system/sbcl)
+    ;; FIXME: Tests fail to load:
+    ;; "The name NIL does not designate any package."
+    ;(arguments `(#:tests? #f))
+    (native-inputs
+     `(("sbcl-cl-ppcre" ,sbcl-cl-ppcre)
+       ("tests:cl-flexi-streams" ,sbcl-flexi-streams)))
+    (home-page "http://weitz.de/cl-unicode/")
+    (synopsis "Portable Unicode library for Common Lisp")
+    (description "CL-UNICODE is a portable Unicode library Common Lisp, which
+is compatible with perl.  It is pretty fast, thread-safe, and compatible with
+ANSI-compliant Common Lisp implementations.")
+    (license license:bsd-2)))
+
 (define-public sbcl-clx
   (let ((revision "1")
         (commit "1c62774b03c1cf3fe6e5cb532df8b14b44c96b95"))
-- 
2.11.0


[-- Attachment #3: Type: text/plain, Size: 89 bytes --]


-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
http://elephly.net

Re: asdf-build-system: Problem running tests for cl-unicode

[ajpatter]

Hi Ricardo,

On Thu, 29 Dec 2016 17:30:53 +0100
Ricardo Wurmus <rekado@elephly.net> wrote:

> Hi,
>
> I’m trying to build a package for sbcl-cl-unicode, which I need for a
> JS uglifier (to be able to generate minified JS files in other
> packages’ build processes).

Since I'm curious, what are you packaging =)?

>
> Unfortunately, the tests fail with
>
>     "The name NIL does not designate any package."
>

The problem seems to have been fixed in the most recent commit, with
the commit logs since the last release suggesting that the definition
file was problematic.

> “cl-unicode” seems to have more problems.  When I ignore the tests and
> try to build “sbcl-cl-ppcre-unicode” (see below), I get an error about
> “CL-UNICODE” not designating any package.
>

I think it's because there's another system in there for
cl-unicode/base, and asdf-build-system needs a package for this. Of
course, this exposes a severe problem with the way the build system
works currently: it can't handle a system with '/' in the name. I hope
to address that in the changes for the build system which I've been
working on.

For now, it's possible to work around it. Attached is a version of your
patch which can build cl-ppcre-unicode.

> Here’s the definition of “sbcl-cl-ppcre-unicode”:
>
> (define-public sbcl-cl-ppcre-unicode
>  (package (inherit sbcl-cl-ppcre)
>    (name "sbcl-cl-ppcre-unicode")
>    (arguments
>     `(#:asd-file "cl-ppcre-unicode.asd"))
>    (inputs
>     `(("sbcl-cl-ppcre" ,sbcl-cl-ppcre)
>       ("sbcl-cl-unicode" ,sbcl-cl-unicode)))))

You'll also need a #:tests? #f here. I'm not fully sure how to fix the
problem - you could drop the #:asd-file but then you'd rebuild
cl-ppcre.

Let me know if this works for the package you're working on.

Thanks,

--
Andy


 From 7739d883078d0be71f07d28c6863688d4f19cdcd Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado@elephly.net>
Date: Thu, 29 Dec 2016 17:30:53 +0100
Subject: [PATCH] WIP gnu: Add sbcl-cl-unicode.

* gnu/packages/lisp.scm (sbcl-cl-unicode-base, sbcl-cl-unicode): New
variables.
---
  gnu/packages/lisp.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
  1 file changed, 43 insertions(+)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index ec0bdaaa5..0887de54a 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -702,6 +702,49 @@ compatible with ANSI-compliant Common Lisp
implementations.") (define-public ecl-cl-ppcre
    (sbcl-package->ecl-package sbcl-cl-ppcre))

+(define sbcl-cl-unicode-base
+  (let ((revision "1")
+        (commit "9fcd06fba1ddc9e66aed2f2d6c32dc9b764f03ea"))
+    (package
+      (name "sbcl-cl-unicode-base")
+      (version "0.1.5")
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/edicl/cl-unicode.git")
+           (commit commit)))
+         (file-name (string-append "cl-unicode-" version "-checkout"))
+         (sha256
+          (base32
+           "1jicprb5b3bv57dy1kg03572gxkcaqdjhak00426s76g0plmx5ki"))
+         (modules '((guix build utils)))
+         (snippet
+          '(substitute* "cl-unicode.asd"
+             (("cl-unicode/base") "cl-unicode-base")))))
+      (build-system asdf-build-system/sbcl)
+      (arguments
+       '(#:asd-file "cl-unicode.asd"))
+      (inputs
+       `(("sbcl-cl-ppcre" ,sbcl-cl-ppcre)))
+      (home-page "http://weitz.de/cl-unicode/")
+      (synopsis "Portable Unicode library for Common Lisp")
+      (description "CL-UNICODE is a portable Unicode library Common
Lisp, which +is compatible with perl.  It is pretty fast, thread-safe,
and compatible with +ANSI-compliant Common Lisp implementations.")
+      (license license:bsd-2))))
+
+(define-public sbcl-cl-unicode
+  (package
+    (inherit sbcl-cl-unicode-base)
+    (name "sbcl-cl-unicode")
+    (inputs
+     `(("sbcl-cl-unicode-base" ,sbcl-cl-unicode-base)
+       ,@(package-inputs sbcl-cl-unicode-base)))
+    (native-inputs
+     `(("tests:cl-flexi-streams" ,sbcl-flexi-streams)))))
+
  (define-public sbcl-clx
    (let ((revision "1")
          (commit "1c62774b03c1cf3fe6e5cb532df8b14b44c96b95"))
-- 
2.11.0

Re: asdf-build-system: Problem running tests for cl-unicode

[ajpatter]

Hi Ricardo,

On Thu, 29 Dec 2016 17:30:53 +0100
Ricardo Wurmus <rekado@elephly.net> wrote:

> Hi,
>
> I’m trying to build a package for sbcl-cl-unicode, which I need for a
> JS uglifier (to be able to generate minified JS files in other
> packages’ build processes).

Since I'm curious, what are you packaging =)?

>
> Unfortunately, the tests fail with
>
>     "The name NIL does not designate any package."
>

The problem seems to have been fixed in the most recent commit, with
the commit logs since the last release suggesting that the definition
file was problematic.

> “cl-unicode” seems to have more problems.  When I ignore the tests and
> try to build “sbcl-cl-ppcre-unicode” (see below), I get an error about
> “CL-UNICODE” not designating any package.
>

I think it's because there's another system in there for
cl-unicode/base, and asdf-build-system needs a package for this. Of
course, this exposes a severe problem with the way the build system
works currently: it can't handle a system with '/' in the name. I hope
to address that in the changes for the build system which I've been
working on.

For now, it's possible to work around it. Attached is a version of your
patch which can build cl-ppcre-unicode.

> Here’s the definition of “sbcl-cl-ppcre-unicode”:
>
> (define-public sbcl-cl-ppcre-unicode
>  (package (inherit sbcl-cl-ppcre)
>    (name "sbcl-cl-ppcre-unicode")
>    (arguments
>     `(#:asd-file "cl-ppcre-unicode.asd"))
>    (inputs
>     `(("sbcl-cl-ppcre" ,sbcl-cl-ppcre)
>       ("sbcl-cl-unicode" ,sbcl-cl-unicode)))))

You'll also need a #:tests? #f here. I'm not fully sure how to fix the
problem - you could drop the #:asd-file but then you'd rebuild
cl-ppcre.

Let me know if this works for the package you're working on.

Thanks,

--
Andy


 From 7739d883078d0be71f07d28c6863688d4f19cdcd Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado@elephly.net>
Date: Thu, 29 Dec 2016 17:30:53 +0100
Subject: [PATCH] WIP gnu: Add sbcl-cl-unicode.

* gnu/packages/lisp.scm (sbcl-cl-unicode-base, sbcl-cl-unicode): New
variables.
---
  gnu/packages/lisp.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
  1 file changed, 43 insertions(+)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index ec0bdaaa5..0887de54a 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -702,6 +702,49 @@ compatible with ANSI-compliant Common Lisp
implementations.") (define-public ecl-cl-ppcre
    (sbcl-package->ecl-package sbcl-cl-ppcre))

+(define sbcl-cl-unicode-base
+  (let ((revision "1")
+        (commit "9fcd06fba1ddc9e66aed2f2d6c32dc9b764f03ea"))
+    (package
+      (name "sbcl-cl-unicode-base")
+      (version "0.1.5")
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/edicl/cl-unicode.git")
+           (commit commit)))
+         (file-name (string-append "cl-unicode-" version "-checkout"))
+         (sha256
+          (base32
+           "1jicprb5b3bv57dy1kg03572gxkcaqdjhak00426s76g0plmx5ki"))
+         (modules '((guix build utils)))
+         (snippet
+          '(substitute* "cl-unicode.asd"
+             (("cl-unicode/base") "cl-unicode-base")))))
+      (build-system asdf-build-system/sbcl)
+      (arguments
+       '(#:asd-file "cl-unicode.asd"))
+      (inputs
+       `(("sbcl-cl-ppcre" ,sbcl-cl-ppcre)))
+      (home-page "http://weitz.de/cl-unicode/")
+      (synopsis "Portable Unicode library for Common Lisp")
+      (description "CL-UNICODE is a portable Unicode library Common
Lisp, which +is compatible with perl.  It is pretty fast, thread-safe,
and compatible with +ANSI-compliant Common Lisp implementations.")
+      (license license:bsd-2))))
+
+(define-public sbcl-cl-unicode
+  (package
+    (inherit sbcl-cl-unicode-base)
+    (name "sbcl-cl-unicode")
+    (inputs
+     `(("sbcl-cl-unicode-base" ,sbcl-cl-unicode-base)
+       ,@(package-inputs sbcl-cl-unicode-base)))
+    (native-inputs
+     `(("tests:cl-flexi-streams" ,sbcl-flexi-streams)))))
+
  (define-public sbcl-clx
    (let ((revision "1")
          (commit "1c62774b03c1cf3fe6e5cb532df8b14b44c96b95"))
-- 
2.11.0