unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Vong <alexvong1995@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: 'package-name-version' and 'strip-store-file-name' does the same thing with different ways
Date: Wed, 17 Oct 2018 06:04:52 +0800	[thread overview]
Message-ID: <87a7ndfszf.fsf@gmail.com> (raw)
In-Reply-To: <874ldmgl8p.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 16 Oct 2018 13:54:30 +0200")

[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]

Hi Ludo,

ludo@gnu.org (Ludovic Courtès) writes:

> Hello Alex,
>
> Alex Vong <alexvong1995@gmail.com> skribis:
>
>> I think we should remove the ones not defined in (guix build utils) and
>> provide 'package-name-version' as alias for 'strip-store-file-name' in
>> (guix build utils). What do you think?
>
> I think we can simply keep ‘strip-store-file-name’, without the alias,
> and modify existing code to use it.
>
OK.

> (That may trigger a lot of rebuilds though, so we’ll have to see which
> branch to apply it to.)
>
> Thanks for noticing!
>
You're welcomed!

> Ludo’.

Btw, I also noticed that the procedure 'flatten' are defined in
(gnu services telephony), (gnu services web) and (guix import utils).
[I was about to define my own version of it...]
I like the version using 'fold-right' together with 'match-lambda*' the
most. Should we move it (guix build utils) and remove the rest?

Similarly, 'file-sans-extension' are defined in both (guix utils) and
(guix build guile-build-system). They are both the same. Should we move
them to (guix build utils) as well?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2018-10-16 22:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-15 19:26 'package-name-version' and 'strip-store-file-name' does the same thing with different ways Alex Vong
2018-10-16 11:54 ` Ludovic Courtès
2018-10-16 22:04   ` Alex Vong [this message]
2018-10-19 13:52     ` Ludovic Courtès
2018-10-19 18:28       ` Alex Vong
2018-10-20 13:24         ` Ludovic Courtès
2018-10-20  8:37       ` Ricardo Wurmus
2018-10-20 13:57         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7ndfszf.fsf@gmail.com \
    --to=alexvong1995@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).