From: "Ludovic Courtès" <ludo@gnu.org>
To: Robert Vollmert <rob@vllmrt.net>
Cc: guix-devel@gnu.org
Subject: Re: ci for wip-haskell-updates
Date: Thu, 25 Jul 2019 19:38:48 +0200 [thread overview]
Message-ID: <87a7d2rp3r.fsf@gnu.org> (raw)
In-Reply-To: <DEAAA11D-0C96-45E8-A519-55E28E584A6C@vllmrt.net> (Robert Vollmert's message of "Mon, 22 Jul 2019 22:57:23 +0200")
Hi,
Robert Vollmert <rob@vllmrt.net> skribis:
>>> The current status of the evaluation of wip-haskell-updates is quite
>>> confusing. There are a number of jobs listed as “Scheduled” with a red
>>> X mark at the front. Is this a bug?
>>
>> I think I found what causes this: Those jobs were actually in state
>> “started”, which fell through to failed.
>>
>> The patch below should complete the list, and make falling through
>> noticeable:
>
> Apologies, I’d truncated the patch. A dedicated “started” icon would
> be nice, too, but I didn’t find anything fitting in the font.
Good catch!
> diff --git a/src/cuirass/templates.scm b/src/cuirass/templates.scm
> index ab1b85c..7fab879 100644
> --- a/src/cuirass/templates.scm
> +++ b/src/cuirass/templates.scm
> @@ -130,27 +130,40 @@
> (define status (assq-ref build #:status))
> (define display-status
> (cond
> - ((= (build-status succeeded) status)
> - `(span (@ (class "oi oi-check text-success")
> - (title "Succeeded"))
> - " Success"))
In general please try to minimize patches; in this case, I think this
hunk can remain here.
> (else
> - `(span (@ (class "oi oi-x text-danger")
> - (title "Failed"))
> - " Failed"))))
> + `(span (@ (class "oi oi-warning text-danger")
> + (title "Invalid status"))
> + " Invalid status"))))
Much better!
Please push to cuirass.git (with a commit log).
Thank you!
Ludo’.
next prev parent reply other threads:[~2019-07-25 17:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 17:39 ci for wip-haskell-updates Robert Vollmert
2019-07-22 19:01 ` Ricardo Wurmus
2019-07-22 19:50 ` Robert Vollmert
2019-07-22 20:44 ` Robert Vollmert
2019-07-22 20:57 ` Robert Vollmert
2019-07-25 17:38 ` Ludovic Courtès [this message]
2019-07-31 14:52 ` Robert Vollmert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7d2rp3r.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rob@vllmrt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).