From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: ci for wip-haskell-updates
Date: Thu, 25 Jul 2019 19:38:48 +0200
Message-ID: <87a7d2rp3r.fsf@gnu.org>
References: <B07BACFF-6BE3-45B6-982A-4B286544FA06@vllmrt.net>
 <87muh5dhax.fsf@elephly.net>
 <99509849-CFA2-4729-8FDC-D1A7798C73ED@vllmrt.net>
 <94456E8D-9AEF-4F47-9617-59773C853C64@vllmrt.net>
 <DEAAA11D-0C96-45E8-A519-55E28E584A6C@vllmrt.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:44699)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <ludo@gnu.org>) id 1hqhhe-0002q1-Mv
 for guix-devel@gnu.org; Thu, 25 Jul 2019 13:38:55 -0400
In-Reply-To: <DEAAA11D-0C96-45E8-A519-55E28E584A6C@vllmrt.net> (Robert
 Vollmert's message of "Mon, 22 Jul 2019 22:57:23 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Robert Vollmert <rob@vllmrt.net>
Cc: guix-devel@gnu.org

Hi,

Robert Vollmert <rob@vllmrt.net> skribis:

>>> The current status of the evaluation of wip-haskell-updates is quite
>>> confusing. There are a number of jobs listed as =E2=80=9CScheduled=E2=
=80=9D with a red
>>> X mark at the front. Is this a bug?
>>=20
>> I think I found what causes this: Those jobs were actually in state
>> =E2=80=9Cstarted=E2=80=9D, which fell through to failed.
>>=20
>> The patch below should complete the list, and make falling through
>> noticeable:
>
> Apologies, I=E2=80=99d truncated the patch. A dedicated =E2=80=9Cstarted=
=E2=80=9D icon would
> be nice, too, but I didn=E2=80=99t find anything fitting in the font.

Good catch!

> diff --git a/src/cuirass/templates.scm b/src/cuirass/templates.scm
> index ab1b85c..7fab879 100644
> --- a/src/cuirass/templates.scm
> +++ b/src/cuirass/templates.scm
> @@ -130,27 +130,40 @@
>    (define status (assq-ref build #:status))
>    (define display-status
>      (cond
> -     ((=3D (build-status succeeded) status)
> -      `(span (@ (class "oi oi-check text-success")
> -                (title "Succeeded"))
> -             " Success"))

In general please try to minimize patches; in this case, I think this
hunk can remain here.

>       (else
> -      `(span (@ (class "oi oi-x text-danger")
> -                (title "Failed"))
> -             " Failed"))))
> +      `(span (@ (class "oi oi-warning text-danger")
> +                (title "Invalid status"))
> +             " Invalid status"))))

Much better!

Please push to cuirass.git (with a commit log).

Thank you!

Ludo=E2=80=99.