From: ludo@gnu.org (Ludovic Courtès)
To: guix-devel@gnu.org
Subject: Re: 01/01: gnu: Add agg.
Date: Wed, 18 Mar 2015 21:40:28 +0100 [thread overview]
Message-ID: <877fuedooz.fsf@gnu.org> (raw)
In-Reply-To: <20150318134720.GA27555@venom> ("Tomáš Čech"'s message of "Wed, 18 Mar 2015 14:47:20 +0100")
Tomáš Čech <sleep_walker@gnu.org> skribis:
> On Wed, Mar 18, 2015 at 02:09:49PM +0100, Ludovic Courtès wrote:
>>Tomas Cech <sleep_walker@suse.cz> skribis:
[...]
>>> +@@ -8,7 +8,6 @@
>>> + AC_PROG_CC
>>> + AC_PROG_CXX
>>> + AC_ISC_POSIX
>>> +-AM_C_PROTOTYPES
>>> + if test "x$U" != "x"; then
>>> + AC_MSG_ERROR(Compiler not ANSI compliant)
>>> + fi
>>
>>It is best to avoid modifying .ac or .am files because that requires
>>adding a dependency on the autotools.]
>
> I will remember that but I'm afraid that in this case there is no
> configure in tarball anyway and has to be generated.
Oh, right, sorry for the confusion! If that has to be generated anyway,
then fine, no problem.
>>What problem does this patch solve? I’m confident this can be worked
>>around without modifying the .ac file, for instance by passing the right
>>ac_cv_ variable as a ‘configure’ argument.
>
>
> AM_C_PROTOTYPES has been removed from automake.
>
> https://lists.gnu.org/archive/html/automake-patches/2011-06/msg00082.html
Right, so you made the right decision. Just mention it in the patch.
Thank you!
Ludo’.
next prev parent reply other threads:[~2015-03-18 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150318105410.2359.97929@vcs.savannah.gnu.org>
[not found] ` <E1YYBc3-0000d6-3W@vcs.savannah.gnu.org>
2015-03-18 13:09 ` 01/01: gnu: Add agg Ludovic Courtès
2015-03-18 13:47 ` Tomáš Čech
2015-03-18 20:40 ` Ludovic Courtès [this message]
2015-03-18 22:08 ` [PATCH] gnu: agg: Add explanatory comment to the patch Tomáš Čech
2015-03-19 16:02 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fuedooz.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).