From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: 01/01: gnu: Add agg.
Date: Wed, 18 Mar 2015 21:40:28 +0100
Message-ID: <877fuedooz.fsf@gnu.org>
References: <20150318105410.2359.97929@vcs.savannah.gnu.org>
	<E1YYBc3-0000d6-3W@vcs.savannah.gnu.org> <87r3smfo4i.fsf@gnu.org>
	<20150318134720.GA27555@venom>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57631)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YYKlb-0005wj-Oo
	for guix-devel@gnu.org; Wed, 18 Mar 2015 16:40:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YYKlX-00047v-G3
	for guix-devel@gnu.org; Wed, 18 Mar 2015 16:40:39 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39823)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YYKlX-00047o-57
	for guix-devel@gnu.org; Wed, 18 Mar 2015 16:40:35 -0400
Received: from reverse-83.fdn.fr ([80.67.176.83]:56125 helo=pluto)
	by fencepost.gnu.org with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <ludo@gnu.org>) id 1YYKlS-0007fN-Ha
	for guix-devel@gnu.org; Wed, 18 Mar 2015 16:40:34 -0400
In-Reply-To: <20150318134720.GA27555@venom> (=?utf-8?B?IlRvbcOhxaEgxIxl?=
	=?utf-8?B?Y2giJ3M=?= message of "Wed, 18 Mar 2015 14:47:20 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: guix-devel@gnu.org

Tom=C3=A1=C5=A1 =C4=8Cech <sleep_walker@gnu.org> skribis:

> On Wed, Mar 18, 2015 at 02:09:49PM +0100, Ludovic Court=C3=A8s wrote:
>>Tomas Cech <sleep_walker@suse.cz> skribis:

[...]

>>> +@@ -8,7 +8,6 @@
>>> + AC_PROG_CC
>>> + AC_PROG_CXX
>>> + AC_ISC_POSIX
>>> +-AM_C_PROTOTYPES
>>> + if test "x$U" !=3D "x"; then
>>> +   AC_MSG_ERROR(Compiler not ANSI compliant)
>>> + fi
>>
>>It is best to avoid modifying .ac or .am files because that requires
>>adding a dependency on the autotools.]
>
> I will remember that but I'm afraid that in this case there is no
> configure in tarball anyway and has to be generated.

Oh, right, sorry for the confusion!  If that has to be generated anyway,
then fine, no problem.

>>What problem does this patch solve?  I=E2=80=99m confident this can be wo=
rked
>>around without modifying the .ac file, for instance by passing the right
>>ac_cv_ variable as a =E2=80=98configure=E2=80=99 argument.
>
>
> AM_C_PROTOTYPES has been removed from automake.
>
> https://lists.gnu.org/archive/html/automake-patches/2011-06/msg00082.html

Right, so you made the right decision.  Just mention it in the patch.

Thank you!

Ludo=E2=80=99.