unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH 2/3] doc: Send changes in your patch which are related.
@ 2016-07-21 18:05 ng0
  2016-07-28 13:48 ` Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: ng0 @ 2016-07-21 18:05 UTC (permalink / raw)
  To: guix-devel

From 0e84643a50d578b6b5bb68119b35dc92d90dafd5 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@we.make.ritual.n0.is>
Date: Thu, 21 Jul 2016 13:24:36 +0000
Subject: [PATCH 2/3] doc: Send changes in your patch which are related.

* doc/contributing.texi (Submitting Patches): New @item:
This gives information about sending related changes and examples on
what we view as related changes.
---
 doc/contributing.texi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index b6f9771..323fcaa 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -323,6 +323,21 @@ related to the hardware---e.g., use of different instruction set
 extensions---or to the operating system kernel---e.g., reliance on
 @code{uname} or @file{/proc} files.

+@item
+Send changes in your patch which are related.  If you send several
+unrelated changes together, we will ask you to separate them so that we
+can work more efficiently on them.  Bundling unrelated changes together
+in big patches makes reviewing harder and slows down the time to apply
+them.
+
+Examples for related changes are: You changed URLs from http to
+https in one file.  You wrote a new service which required adding
+documentation about it.  You discovered that a new version of an
+application was released and updated it, but this required new
+dependencies and small fixes.
+If you combine more than one example in one patch you get examples
+for what we understand as mixing changes.
+
 @end enumerate

 When posting a patch to the mailing list, use @samp{[PATCH] @dots{}} as
--
2.9.1


--
♥Ⓐ  ng0 – http://we.make.ritual.n0.is
For non-prism friendly talk find me on http://www.psyced.org
SecuShare – http://secushare.org

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/3] doc: Send changes in your patch which are related.
  2016-07-21 18:05 [PATCH 2/3] doc: Send changes in your patch which are related ng0
@ 2016-07-28 13:48 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2016-07-28 13:48 UTC (permalink / raw)
  To: ng0; +Cc: guix-devel

ng0 <ng0@we.make.ritual.n0.is> skribis:

> From 0e84643a50d578b6b5bb68119b35dc92d90dafd5 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@we.make.ritual.n0.is>
> Date: Thu, 21 Jul 2016 13:24:36 +0000
> Subject: [PATCH 2/3] doc: Send changes in your patch which are related.
>
> * doc/contributing.texi (Submitting Patches): New @item:
> This gives information about sending related changes and examples on
> what we view as related changes.

Applied with slightly different wording, thanks!

Ludo’.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-07-28 13:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-21 18:05 [PATCH 2/3] doc: Send changes in your patch which are related ng0
2016-07-28 13:48 ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).