[PATCH] doc: Suggest installing gvfs.

[PATCH] doc: Suggest installing gvfs.

[Ricardo Wurmus]

* gnu/system/examples/desktop.tmpl: Add gvfs to the system-wide list of
packages.
---
 gnu/system/examples/desktop.tmpl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/system/examples/desktop.tmpl b/gnu/system/examples/desktop.tmpl
index 82687e7..21b4563 100644
--- a/gnu/system/examples/desktop.tmpl
+++ b/gnu/system/examples/desktop.tmpl
@@ -4,7 +4,7 @@
 
 (use-modules (gnu) (gnu system nss))
 (use-service-modules desktop)
-(use-package-modules certs)
+(use-package-modules certs gnome)
 
 (operating-system
   (host-name "antelope")
@@ -42,6 +42,7 @@
 
   ;; This is where we specify system-wide packages.
   (packages (cons* nss-certs         ;for HTTPS access
+                   gvfs              ;for user mounts
                    %base-packages))
 
   ;; Add GNOME and/or Xfce---we can choose at the log-in
-- 
2.10.2

Re: [PATCH] doc: Suggest installing gvfs.

[Mathieu Lirzin]

Hi,

Ricardo Wurmus <rekado@elephly.net> writes:

> * gnu/system/examples/desktop.tmpl: Add gvfs to the system-wide list of
> packages.
> ---
>  gnu/system/examples/desktop.tmpl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/system/examples/desktop.tmpl b/gnu/system/examples/desktop.tmpl
> index 82687e7..21b4563 100644
> --- a/gnu/system/examples/desktop.tmpl
> +++ b/gnu/system/examples/desktop.tmpl
> @@ -4,7 +4,7 @@
>  
>  (use-modules (gnu) (gnu system nss))
>  (use-service-modules desktop)
> -(use-package-modules certs)
> +(use-package-modules certs gnome)
>  
>  (operating-system
>    (host-name "antelope")
> @@ -42,6 +42,7 @@
>  
>    ;; This is where we specify system-wide packages.
>    (packages (cons* nss-certs         ;for HTTPS access
> +                   gvfs              ;for user mounts
>                     %base-packages))
>  
>    ;; Add GNOME and/or Xfce---we can choose at the log-in

IMO 'gvfs' is a reasonable default for a desktop configuration.  So I
think this patch is a good idea.

Thanks.

-- 
Mathieu Lirzin

Re: [PATCH] doc: Suggest installing gvfs.

[Ricardo Wurmus]

Mathieu Lirzin <mthl@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> * gnu/system/examples/desktop.tmpl: Add gvfs to the system-wide list of
>> packages.
>> ---
>>  gnu/system/examples/desktop.tmpl | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/system/examples/desktop.tmpl b/gnu/system/examples/desktop.tmpl
>> index 82687e7..21b4563 100644
>> --- a/gnu/system/examples/desktop.tmpl
>> +++ b/gnu/system/examples/desktop.tmpl
>> @@ -4,7 +4,7 @@
>>  
>>  (use-modules (gnu) (gnu system nss))
>>  (use-service-modules desktop)
>> -(use-package-modules certs)
>> +(use-package-modules certs gnome)
>>  
>>  (operating-system
>>    (host-name "antelope")
>> @@ -42,6 +42,7 @@
>>  
>>    ;; This is where we specify system-wide packages.
>>    (packages (cons* nss-certs         ;for HTTPS access
>> +                   gvfs              ;for user mounts
>>                     %base-packages))
>>  
>>    ;; Add GNOME and/or Xfce---we can choose at the log-in
>
> IMO 'gvfs' is a reasonable default for a desktop configuration.  So I
> think this patch is a good idea.
>
> Thanks.

Pushed as e48ddb96282cd231e4aed2255f6b918901a71922.

-- 
Ricardo

Re: [PATCH] doc: Suggest installing gvfs.

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/system/examples/desktop.tmpl: Add gvfs to the system-wide list of
> packages.
> ---
>  gnu/system/examples/desktop.tmpl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/system/examples/desktop.tmpl b/gnu/system/examples/desktop.tmpl
> index 82687e7..21b4563 100644
> --- a/gnu/system/examples/desktop.tmpl
> +++ b/gnu/system/examples/desktop.tmpl
> @@ -4,7 +4,7 @@
>  
>  (use-modules (gnu) (gnu system nss))
>  (use-service-modules desktop)
> -(use-package-modules certs)
> +(use-package-modules certs gnome)
>  
>  (operating-system
>    (host-name "antelope")
> @@ -42,6 +42,7 @@
>  
>    ;; This is where we specify system-wide packages.
>    (packages (cons* nss-certs         ;for HTTPS access
> +                   gvfs              ;for user mounts

What about adding it to the ‘gnome’ meta-package instead?  (That
meta-package gets installed in the global profile by
‘gnome-desktop-service-type’.)

Ludo’.

Re: [PATCH] doc: Suggest installing gvfs.

[Ricardo Wurmus]

Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> * gnu/system/examples/desktop.tmpl: Add gvfs to the system-wide list of
>> packages.
>> ---
>>  gnu/system/examples/desktop.tmpl | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/system/examples/desktop.tmpl b/gnu/system/examples/desktop.tmpl
>> index 82687e7..21b4563 100644
>> --- a/gnu/system/examples/desktop.tmpl
>> +++ b/gnu/system/examples/desktop.tmpl
>> @@ -4,7 +4,7 @@
>>  
>>  (use-modules (gnu) (gnu system nss))
>>  (use-service-modules desktop)
>> -(use-package-modules certs)
>> +(use-package-modules certs gnome)
>>  
>>  (operating-system
>>    (host-name "antelope")
>> @@ -42,6 +42,7 @@
>>  
>>    ;; This is where we specify system-wide packages.
>>    (packages (cons* nss-certs         ;for HTTPS access
>> +                   gvfs              ;for user mounts
>
> What about adding it to the ‘gnome’ meta-package instead?  (That
> meta-package gets installed in the global profile by
> ‘gnome-desktop-service-type’.)

I’m sorry, I didn’t see your email before my reply to Mathieu and the
my decision to push!

“gvfs” is useful for more than just GNOME.  For a long time I tried to
figure out why USB devices would not be mounted automatically in Xfce
and I ran gvfsd and the gvfs-* device monitor daemons manually — until
today when I understood that these daemons are supposed to be started
automatically if only the DBUS service files were found.

We probably should add it to the “gnome” meta-package, and additionally
document in the manual that gvfs must be installed system-wide to allow
DBUS to find the service files and start the monitoring daemons on
demand.

What do you think?  If that’s okay I’ll prepare a patch for this.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
http://elephly.net

Re: [PATCH] doc: Suggest installing gvfs.

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

Ricardo Wurmus <rekado@elephly.net> skribis:

> “gvfs” is useful for more than just GNOME.  For a long time I tried to
> figure out why USB devices would not be mounted automatically in Xfce
> and I ran gvfsd and the gvfs-* device monitor daemons manually — until
> today when I understood that these daemons are supposed to be started
> automatically if only the DBUS service files were found.
>
> We probably should add it to the “gnome” meta-package, and additionally
> document in the manual that gvfs must be installed system-wide to allow
> DBUS to find the service files and start the monitoring daemons on
> demand.

If it’s not specific to GNOME, what about adding it to
‘%desktop-services’?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 438 bytes --]

diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 7555780..c359035 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -754,6 +754,7 @@ with the administrator's password."
          (screen-locker-service xlockmore "xlock")
 
          ;; The D-Bus clique.
+         (simple-service 'gvfsd dbus-root-service-type gvfs)
          (avahi-service)
          (wicd-service)
          (udisks-service)

[-- Attachment #3: Type: text/plain, Size: 12 bytes --]


Ludo’.

Re: [PATCH] doc: Suggest installing gvfs.

[Ricardo Wurmus]

Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> “gvfs” is useful for more than just GNOME.  For a long time I tried to
>> figure out why USB devices would not be mounted automatically in Xfce
>> and I ran gvfsd and the gvfs-* device monitor daemons manually — until
>> today when I understood that these daemons are supposed to be started
>> automatically if only the DBUS service files were found.
>>
>> We probably should add it to the “gnome” meta-package, and additionally
>> document in the manual that gvfs must be installed system-wide to allow
>> DBUS to find the service files and start the monitoring daemons on
>> demand.
>
> If it’s not specific to GNOME, what about adding it to
> ‘%desktop-services’?

How would that work?  “gvfs” doesn’t provide any services that would be
run as root.  It only comes with dbus service files; the daemons are
started as the current user on demand over dbus when certain libraries
are loaded.

Should I write dbus services for each of the daemons and extend the
dbus-root-service-type?  (I’m not sure how to do this but I could try.)

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
http://elephly.net

Re: [PATCH] doc: Suggest installing gvfs.

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]

Ricardo Wurmus <rekado@elephly.net> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Ricardo Wurmus <rekado@elephly.net> skribis:
>>
>>> “gvfs” is useful for more than just GNOME.  For a long time I tried to
>>> figure out why USB devices would not be mounted automatically in Xfce
>>> and I ran gvfsd and the gvfs-* device monitor daemons manually — until
>>> today when I understood that these daemons are supposed to be started
>>> automatically if only the DBUS service files were found.
>>>
>>> We probably should add it to the “gnome” meta-package, and additionally
>>> document in the manual that gvfs must be installed system-wide to allow
>>> DBUS to find the service files and start the monitoring daemons on
>>> demand.
>>
>> If it’s not specific to GNOME, what about adding it to
>> ‘%desktop-services’?
>
> How would that work?

This patch extends DBus with gvfs, since you said gvfs is a set of DBus
services (I didn’t check).  If gvfs provides DBus service definition
files, then DBus will automatically pick them and start the services on
demand.

> “gvfs” doesn’t provide any services that would be run as root.  It
> only comes with dbus service files; the daemons are started as the
> current user on demand over dbus when certain libraries are loaded.

OK, so that was the wrong approach.

In that case, what about adding the package to the global profile like
this:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 608 bytes --]

diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 7555780..5d02bd0 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -753,6 +753,10 @@ with the administrator's password."
          (screen-locker-service slock)
          (screen-locker-service xlockmore "xlock")
 
+         ;; GVFS is used by both GNOME and Xfce.  It provides DBus services
+         ;; started on behalf of users, and those daemons need to be in $PATH.
+         (simple-service 'gvfs profile-service-type gvfs)
+
          ;; The D-Bus clique.
          (avahi-service)
          (wicd-service)

[-- Attachment #3: Type: text/plain, Size: 21 bytes --]


Thanks,
Ludo’.

Re: [PATCH] doc: Suggest installing gvfs.

[Ludovic Courtès]

Hi Ricardo!

ludo@gnu.org (Ludovic Courtès) skribis:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> Ricardo Wurmus <rekado@elephly.net> skribis:
>>>
>>>> “gvfs” is useful for more than just GNOME.  For a long time I tried to
>>>> figure out why USB devices would not be mounted automatically in Xfce
>>>> and I ran gvfsd and the gvfs-* device monitor daemons manually — until
>>>> today when I understood that these daemons are supposed to be started
>>>> automatically if only the DBUS service files were found.
>>>>
>>>> We probably should add it to the “gnome” meta-package, and additionally
>>>> document in the manual that gvfs must be installed system-wide to allow
>>>> DBUS to find the service files and start the monitoring daemons on
>>>> demand.
>>>
>>> If it’s not specific to GNOME, what about adding it to
>>> ‘%desktop-services’?
>>
>> How would that work?
>
> This patch extends DBus with gvfs, since you said gvfs is a set of DBus
> services (I didn’t check).  If gvfs provides DBus service definition
> files, then DBus will automatically pick them and start the services on
> demand.
>
>> “gvfs” doesn’t provide any services that would be run as root.  It
>> only comes with dbus service files; the daemons are started as the
>> current user on demand over dbus when certain libraries are loaded.
>
> OK, so that was the wrong approach.
>
> In that case, what about adding the package to the global profile like
> this:
>
> diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
> index 7555780..5d02bd0 100644
> --- a/gnu/services/desktop.scm
> +++ b/gnu/services/desktop.scm
> @@ -753,6 +753,10 @@ with the administrator's password."
>           (screen-locker-service slock)
>           (screen-locker-service xlockmore "xlock")
>  
> +         ;; GVFS is used by both GNOME and Xfce.  It provides DBus services
> +         ;; started on behalf of users, and those daemons need to be in $PATH.
> +         (simple-service 'gvfs profile-service-type gvfs)
> +
>           ;; The D-Bus clique.
>           (avahi-service)
>           (wicd-service)

Should we do this?  I would test it but I don’t know how.

Ludo’.