Re: Bug in strip phase of gnu-build-system?

[Mark H Weaver <mhw@netris.org>]

Hi,

elaexuotee@wilsonb.com writes:

> Hello,
>
> Sanity check, please.
>
> When `strip-binaries?` is `#f` and a "debug" output is defined, said output
> remains empty. Instead, I expect "debug" to get populated with separated debug
> files.
>
> The logic for creating debug files exists in (guix build gnu-build-system)
> under the definition of `strip`. In particular `strip-dir` extracts the debug
> info into "debug" if and only fi that output exists.
>
> Note, that (guix build-system gnu) already removes "debug" from the outputs
> when strip-binaries? is true.
>
> However, for some reason the actual `strip-dir1 invocation is wrapped in a (if
> strip-binaries? ...) check, meaning that the entire phase becomes a no-op.
> Shouldn't that if check be removed?
>
> I have CC'ed Mark Weaver, since it looks like he is the author of this
> particular if block.

The conditional was originally introduced by Ludovic, here:

  https://git.sv.gnu.org/cgit/guix.git/commit/?id=877217b85ac318a0a702578f183dd638c9704112

My role was merely to reformulate the conditional as a 'when' instead of
an 'or', while making an unrelated change in a later commit, here:

  https://git.sv.gnu.org/cgit/guix.git/commit/?id=9a87649c863e1ff8b073b356875eb05eecedbcf7

I've never studied this corner of Guix, and I don't have time to do so,
but perhaps Ludovic can respond further.

     Regards,
       Mark

-- 
Disinformation flourishes because many people care deeply about injustice
but very few check the facts.  Ask me about <https://stallmansupport.org>.