From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uEBGINV9wWLe3QAAbAwnHQ (envelope-from ) for ; Sun, 03 Jul 2022 13:30:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 0PwmINV9wWKqLQEAauVa8A (envelope-from ) for ; Sun, 03 Jul 2022 13:30:29 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 40C671922E for ; Sun, 3 Jul 2022 13:30:29 +0200 (CEST) Received: from localhost ([::1]:35576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o7xo3-0004po-So for larch@yhetil.org; Sun, 03 Jul 2022 07:30:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7xne-0004pd-I1 for guix-devel@gnu.org; Sun, 03 Jul 2022 07:30:02 -0400 Received: from world.peace.net ([64.112.178.59]:34752) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7xnc-000187-OI; Sun, 03 Jul 2022 07:30:02 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o7xmV-0004wz-Hp; Sun, 03 Jul 2022 07:28:51 -0400 From: Mark H Weaver To: elaexuotee@wilsonb.com, guix-devel@gnu.org Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: Bug in strip phase of gnu-build-system? In-Reply-To: <2VI4GBZMQD9RW.2FY92Z2FZID5O@"@WILSONB.COM> References: <2VI4GBZMQD9RW.2FY92Z2FZID5O@"@WILSONB.COM> Date: Sun, 03 Jul 2022 07:28:39 -0400 Message-ID: <877d4umo3h.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656847829; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=u1Et5hxCaHuv7Yvmkqwj4RphG8MSJqvlatjcgngnCG0=; b=IVQV+6YGitpOFeFYlK/V0QKL1mCNWmqg6SWIvRaSuECmZYpFQxn391w3aAAnOsHqFXnBWI 4ZuGPJYyCXLt66j071l6MLZfhAceov5CLLHELgMp8T9aSSR9LAqCOmvpcYlmWgvsEsv7yg uY2aLObOhzS1M1H3AO5QtQprUE2gKQwLeUUJVMPjp/VYhZAEOO0jya2V7na4KVn51aM4CQ GnZ7u232QBn96pV+BZsoqaQzJpjK9IwhVrCx2QlUxUNCboWJqqvbd/Q61TbNx+dDt3HDL2 palRQyghtHtguIS7smlLL2CYaAeUm7KdhT9QaG43utFLKpmMt3afzrE6V4AfPQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656847829; a=rsa-sha256; cv=none; b=oZDYLKfxpUsrWQaZS5xkimpTM/JijDwU3IOqVTGnMGkvAPB1tBrQkU6UnIDlFnH5vkTxxw fZoG4aPtiyQa6aeAKXIAXX01mVpY4eosFDhVzoPxgrKASzZwueQumi8tt1AJDFO+5NM0e/ MzpG1miXAloKCipZiE8ij6WOmDh3cJUmtJn1vwUjABWwRJl0Gq7uin0gM7LHzk5BrZ70f/ FmadvjtRl4i6B1LGJU32ARMXVgWLSj1VVPzQAFuYEcoEtsHNhW1GoCqSr8gjAkLcMRBOYc LZZEPXPKunOXSCbcu4HuSRQ3j5z4vTba1GnUmcRYZBQuFSRCRr49/xb4fK8Dcw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.85 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 40C671922E X-Spam-Score: -2.85 X-Migadu-Scanner: scn0.migadu.com X-TUID: PWVtOx70iwBH Hi, elaexuotee@wilsonb.com writes: > Hello, > > Sanity check, please. > > When `strip-binaries?` is `#f` and a "debug" output is defined, said output > remains empty. Instead, I expect "debug" to get populated with separated debug > files. > > The logic for creating debug files exists in (guix build gnu-build-system) > under the definition of `strip`. In particular `strip-dir` extracts the debug > info into "debug" if and only fi that output exists. > > Note, that (guix build-system gnu) already removes "debug" from the outputs > when strip-binaries? is true. > > However, for some reason the actual `strip-dir1 invocation is wrapped in a (if > strip-binaries? ...) check, meaning that the entire phase becomes a no-op. > Shouldn't that if check be removed? > > I have CC'ed Mark Weaver, since it looks like he is the author of this > particular if block. The conditional was originally introduced by Ludovic, here: https://git.sv.gnu.org/cgit/guix.git/commit/?id=877217b85ac318a0a702578f183dd638c9704112 My role was merely to reformulate the conditional as a 'when' instead of an 'or', while making an unrelated change in a later commit, here: https://git.sv.gnu.org/cgit/guix.git/commit/?id=9a87649c863e1ff8b073b356875eb05eecedbcf7 I've never studied this corner of Guix, and I don't have time to do so, but perhaps Ludovic can respond further. Regards, Mark -- Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about .