unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] gnu: Add desktop-file-utils.
@ 2015-01-29 13:09 宋文武
  2015-02-01 21:26 ` Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: 宋文武 @ 2015-01-29 13:09 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/gnome.scm (desktop-file-utils): New variable.
---
 gnu/packages/gnome.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d8b9acf..c42092d 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -313,6 +313,38 @@ Specification, the icon naming utility maps the icon names used by the
 GNOME and KDE desktops to the icon names proposed in the specification.")
     (license license:lgpl2.1+)))
 
+(define-public desktop-file-utils
+  (package
+    (name "desktop-file-utils")
+    (version "0.22")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://www.freedesktop.org/software/" name
+                                  "/releases/" name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "1ianvr2a69yjv4rpyv30w7yjsmnsb23crrka5ndqxycj4rkk4dc4"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("glib" ,glib)))
+    (home-page "http://www.freedesktop.org/wiki/Software/desktop-file-utils/")
+    (synopsis "Utilities for working with desktop entries")
+    (description
+     "This package contains a few command line utilities for working with
+desktop entries:
+
+desktop-file-validate: validates a desktop file and prints warnings/errors
+                       about desktop entry specification violations.
+
+desktop-file-install: installs a desktop file to the applications directory,
+                      optionally munging it a bit in transit.
+
+update-desktop-database: updates the database containing a cache of MIME types
+                         handled by desktop files.")
+    (license license:gpl2+)))
+
 (define-public gnome-icon-theme
   (package
     (name "gnome-icon-theme")
-- 
2.1.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] gnu: Add desktop-file-utils.
  2015-01-29 13:09 [PATCH] gnu: Add desktop-file-utils 宋文武
@ 2015-02-01 21:26 ` Ludovic Courtès
  2015-02-02 10:49   ` 宋文武
  0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2015-02-01 21:26 UTC (permalink / raw)
  To: 宋文武; +Cc: guix-devel

宋文武 <iyzsong@gmail.com> skribis:

> * gnu/packages/gnome.scm (desktop-file-utils): New variable.

[...]

> +    (description
> +     "This package contains a few command line utilities for working with
> +desktop entries:
> +
> +desktop-file-validate: validates a desktop file and prints warnings/errors
> +                       about desktop entry specification violations.
> +
> +desktop-file-install: installs a desktop file to the applications directory,
> +                      optionally munging it a bit in transit.
> +
> +update-desktop-database: updates the database containing a cache of MIME types
> +                         handled by desktop files.")

Could you remove the alignment of lines (because formatting is lost when
using the various tools), and enclose the command names in simple
quotes?

OK to push with that, thanks!

Ludo’.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gnu: Add desktop-file-utils.
  2015-02-01 21:26 ` Ludovic Courtès
@ 2015-02-02 10:49   ` 宋文武
  0 siblings, 0 replies; 3+ messages in thread
From: 宋文武 @ 2015-02-02 10:49 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

Ludovic Courtès <ludo@gnu.org> writes:

> 宋文武 <iyzsong@gmail.com> skribis:
>
>> * gnu/packages/gnome.scm (desktop-file-utils): New variable.
>
> [...]
>
>> +    (description
>> +     "This package contains a few command line utilities for working with
>> +desktop entries:
>> +
>> +desktop-file-validate: validates a desktop file and prints warnings/errors
>> +                       about desktop entry specification violations.
>> +
>> +desktop-file-install: installs a desktop file to the applications directory,
>> +                      optionally munging it a bit in transit.
>> +
>> +update-desktop-database: updates the database containing a cache of MIME types
>> +                         handled by desktop files.")
>
> Could you remove the alignment of lines (because formatting is lost when
> using the various tools), and enclose the command names in simple
> quotes?
>
> OK to push with that, thanks!
>
> Ludo’.
Sorry, I pushed it already :(

Is this patch OK?

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-desktop-file-utils-Adjust-formatting-of-descript.patch --]
[-- Type: text/x-patch, Size: 1625 bytes --]

From 32c4ff2642fac85fceccb7a009131103049dec92 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@gmail.com>
Date: Mon, 2 Feb 2015 18:45:26 +0800
Subject: [PATCH] gnu: desktop-file-utils: Adjust formatting of description.

* gnu/packages/gnome.scm (desktop-file-utils)[description]: Adjust formatting.
---
 gnu/packages/gnome.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c42092d..b99e332 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -335,14 +335,14 @@ GNOME and KDE desktops to the icon names proposed in the specification.")
      "This package contains a few command line utilities for working with
 desktop entries:
 
-desktop-file-validate: validates a desktop file and prints warnings/errors
-                       about desktop entry specification violations.
+'desktop-file-validate': validates a desktop file and prints warnings/errors
+about desktop entry specification violations.
 
-desktop-file-install: installs a desktop file to the applications directory,
-                      optionally munging it a bit in transit.
+'desktop-file-install': installs a desktop file to the applications directory,
+optionally munging it a bit in transit.
 
-update-desktop-database: updates the database containing a cache of MIME types
-                         handled by desktop files.")
+'update-desktop-database': updates the database containing a cache of MIME types
+handled by desktop files.")
     (license license:gpl2+)))
 
 (define-public gnome-icon-theme
-- 
2.1.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-02 10:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-29 13:09 [PATCH] gnu: Add desktop-file-utils 宋文武
2015-02-01 21:26 ` Ludovic Courtès
2015-02-02 10:49   ` 宋文武

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).