* Re: 01/01: services: xorg: Fix file descriptor leak from SLiM/xinitrc.
[not found] ` <E1YRqlM-0002tF-RU@vcs.savannah.gnu.org>
@ 2015-03-02 5:06 ` Mark H Weaver
2015-03-02 9:58 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Mark H Weaver @ 2015-03-02 5:06 UTC (permalink / raw)
To: guix-devel
Ludovic Courtès <ludo@gnu.org> writes:
> commit ec4a4c46efaf2e7373f331654640f1321c0f2e62
> Author: Ludovic Courtès <ludo@gnu.org>
> Date: Sat Feb 28 22:44:31 2015 +0100
>
> services: xorg: Fix file descriptor leak from SLiM/xinitrc.
>
> Previously processes started from the window manager would have a couple
> of leaked file descriptors: writable /var/log/slim.log and readable
> /gnu/store/…-xinitrc.
>
> * gnu/services/xorg.scm (xinitrc)[builder]: Add 'close-all-fdes'. Use
> it in 'exec-from-login-shell'.
This commit broke XFCE, so I've reverted it until we can investigate
further.
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 01/01: services: xorg: Fix file descriptor leak from SLiM/xinitrc.
2015-03-02 5:06 ` 01/01: services: xorg: Fix file descriptor leak from SLiM/xinitrc Mark H Weaver
@ 2015-03-02 9:58 ` Ludovic Courtès
2015-03-02 19:27 ` Mark H Weaver
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2015-03-02 9:58 UTC (permalink / raw)
To: Mark H Weaver; +Cc: guix-devel
Mark H Weaver <mhw@netris.org> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> commit ec4a4c46efaf2e7373f331654640f1321c0f2e62
>> Author: Ludovic Courtès <ludo@gnu.org>
>> Date: Sat Feb 28 22:44:31 2015 +0100
>>
>> services: xorg: Fix file descriptor leak from SLiM/xinitrc.
>>
>> Previously processes started from the window manager would have a couple
>> of leaked file descriptors: writable /var/log/slim.log and readable
>> /gnu/store/…-xinitrc.
>>
>> * gnu/services/xorg.scm (xinitrc)[builder]: Add 'close-all-fdes'. Use
>> it in 'exec-from-login-shell'.
>
> This commit broke XFCE, so I've reverted it until we can investigate
> further.
I’ve had a couple of glitches too, which are apparently due to the fact
that this patch closes FDs 0, 1, and 2, which it shouldn’t.
Can you confirm that starting from FD 3 works for you too?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 01/01: services: xorg: Fix file descriptor leak from SLiM/xinitrc.
2015-03-02 9:58 ` Ludovic Courtès
@ 2015-03-02 19:27 ` Mark H Weaver
0 siblings, 0 replies; 3+ messages in thread
From: Mark H Weaver @ 2015-03-02 19:27 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
ludo@gnu.org (Ludovic Courtès) writes:
> Mark H Weaver <mhw@netris.org> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> commit ec4a4c46efaf2e7373f331654640f1321c0f2e62
>>> Author: Ludovic Courtès <ludo@gnu.org>
>>> Date: Sat Feb 28 22:44:31 2015 +0100
>>>
>>> services: xorg: Fix file descriptor leak from SLiM/xinitrc.
>>>
>>> Previously processes started from the window manager would have a couple
>>> of leaked file descriptors: writable /var/log/slim.log and readable
>>> /gnu/store/…-xinitrc.
>>>
>>> * gnu/services/xorg.scm (xinitrc)[builder]: Add 'close-all-fdes'. Use
>>> it in 'exec-from-login-shell'.
>>
>> This commit broke XFCE, so I've reverted it until we can investigate
>> further.
>
> I’ve had a couple of glitches too, which are apparently due to the fact
> that this patch closes FDs 0, 1, and 2, which it shouldn’t.
>
> Can you confirm that starting from FD 3 works for you too?
Yes, starting from FD 3 works.
Thanks!
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-02 19:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150228232536.11051.24311@vcs.savannah.gnu.org>
[not found] ` <E1YRqlM-0002tF-RU@vcs.savannah.gnu.org>
2015-03-02 5:06 ` 01/01: services: xorg: Fix file descriptor leak from SLiM/xinitrc Mark H Weaver
2015-03-02 9:58 ` Ludovic Courtès
2015-03-02 19:27 ` Mark H Weaver
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).