unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: 01/03: gnu: mozjs: Mark as unsupported on mips64el-linux.
Date: Wed, 06 May 2015 11:54:56 -0400	[thread overview]
Message-ID: <874mnpya3z.fsf@netris.org> (raw)
In-Reply-To: <E1Ypj6O-0003rt-13@vcs.savannah.gnu.org> (Ludovic Court's message of "Tue, 05 May 2015 20:06:00 +0000")

Ludovic Courtès <ludo@gnu.org> writes:

> civodul pushed a commit to branch master
> in repository guix.
>
> commit 4bfeb0ca74fca75febe62b8e059b0c5a6ddd622f
> Author: Ludovic Courtès <ludo@gnu.org>
> Date:   Tue May 5 21:39:18 2015 +0200
>
>     gnu: mozjs: Mark as unsupported on mips64el-linux.

[...]

> diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> index 522404f..8031a6c 100644
> --- a/gnu/packages/gnuzilla.scm
> +++ b/gnu/packages/gnuzilla.scm
> @@ -85,7 +85,12 @@
>      (synopsis "Mozilla javascript engine")
>      (description "SpiderMonkey is Mozilla's JavaScript engine written
>  in C/C++.")
> -    (license license:mpl2.0))) ; and others for some files
> +    (license license:mpl2.0)                      ;and others for some files
> +
> +    ;; On mips64el, this fails to build with several "control reaches end of
> +    ;; non-void function" errors (see
> +    ;; <http://hydra.gnu.org/build/407741/nixlog/3/raw>.)
> +    (supported-systems (delete "mips64el-linux" %supported-systems))))

In general, I would prefer not to mark packages as unsupported on a
platform unless there is good reason to believe that the problems would
be very difficult to resolve.

In this case, Debian contains builds of mozjs for MIPS, and MIPS is
supported by the Mozilla project.  For example, see:

  https://bugzilla.mozilla.org/show_bug.cgi?id=902818

where a mozjs bug is reported on MIPS (N32 ABI) and later fixed by
upstream.

Furthermore, mozjs is an important package.  polkit depends on mozjs,
and several important GNOME components depend on polkit, so without
mozjs we cannot have GNOME on MIPS.

So, I would prefer to revert this commit.  What do you think?

     Mark

       reply	other threads:[~2015-05-06 15:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150505200559.14816.34558@vcs.savannah.gnu.org>
     [not found] ` <E1Ypj6O-0003rt-13@vcs.savannah.gnu.org>
2015-05-06 15:54   ` Mark H Weaver [this message]
2015-05-06 16:25     ` 01/03: gnu: mozjs: Mark as unsupported on mips64el-linux Andreas Enge
2015-05-06 19:55     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mnpya3z.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).