From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: 01/03: gnu: mozjs: Mark as unsupported on mips64el-linux. Date: Wed, 06 May 2015 11:54:56 -0400 Message-ID: <874mnpya3z.fsf@netris.org> References: <20150505200559.14816.34558@vcs.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yq1fL-000616-2l for guix-devel@gnu.org; Wed, 06 May 2015 11:55:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yq1fG-0002KS-Ov for guix-devel@gnu.org; Wed, 06 May 2015 11:55:19 -0400 In-Reply-To: (Ludovic Court's message of "Tue, 05 May 2015 20:06:00 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s writes: > civodul pushed a commit to branch master > in repository guix. > > commit 4bfeb0ca74fca75febe62b8e059b0c5a6ddd622f > Author: Ludovic Court=C3=A8s > Date: Tue May 5 21:39:18 2015 +0200 > > gnu: mozjs: Mark as unsupported on mips64el-linux. [...] > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm > index 522404f..8031a6c 100644 > --- a/gnu/packages/gnuzilla.scm > +++ b/gnu/packages/gnuzilla.scm > @@ -85,7 +85,12 @@ > (synopsis "Mozilla javascript engine") > (description "SpiderMonkey is Mozilla's JavaScript engine written > in C/C++.") > - (license license:mpl2.0))) ; and others for some files > + (license license:mpl2.0) ;and others for some f= iles > + > + ;; On mips64el, this fails to build with several "control reaches en= d of > + ;; non-void function" errors (see > + ;; .) > + (supported-systems (delete "mips64el-linux" %supported-systems)))) In general, I would prefer not to mark packages as unsupported on a platform unless there is good reason to believe that the problems would be very difficult to resolve. In this case, Debian contains builds of mozjs for MIPS, and MIPS is supported by the Mozilla project. For example, see: https://bugzilla.mozilla.org/show_bug.cgi?id=3D902818 where a mozjs bug is reported on MIPS (N32 ABI) and later fixed by upstream. Furthermore, mozjs is an important package. polkit depends on mozjs, and several important GNOME components depend on polkit, so without mozjs we cannot have GNOME on MIPS. So, I would prefer to revert this commit. What do you think? Mark