From: ludo@gnu.org (Ludovic Courtès)
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 07/12] gnu: Add rust bootstrap binaries.
Date: Tue, 13 Dec 2016 23:44:58 +0100 [thread overview]
Message-ID: <874m27mot1.fsf@gnu.org> (raw)
In-Reply-To: <20161211172537.23315-8-david@craven.ch> (David Craven's message of "Sun, 11 Dec 2016 18:25:32 +0100")
David Craven <david@craven.ch> skribis:
> * gnu/packages/rust.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add rust.scm.
There are a couple of comments from
<https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00158.html>
that remain valid, I think. Could you double-check?
> +(define (system->rust-platform system)
> + (cond
> + ((string-prefix? "x86_64" system) "x86_64-unknown-linux-gnu")
> + ((string-prefix? "i686" system) "i686-unknown-linux-gnu")
> + (else #f)))
I think you can remove this procedure and use ‘nix-system->gnu-triplet’
instead.
> + (inputs
> + ;; FIXME: Use system gcc:lib. Does gcc "lib" need to be
> + ;; added to %final-inputs?
> + `(("gcc:lib" ,gcc "lib")
Use (canonical-package gcc).
> +(define-public rust-bootstrap
> + (package
> + (name "rust-bootstrap")
> + (version %rust-bootstrap-binaries-version)
> + (source #f)
> + (build-system trivial-build-system)
> + (propagated-inputs
> + ;; XXX: guix size shows a size of zero. Are propagated inputs not
> + ;; counted?
> + `(("rustc-bootstrap" ,rustc-bootstrap)
> + ("cargo-bootstrap" ,cargo-bootstrap)))
> + (arguments
> + `(#:builder
> + (begin (mkdir (assoc-ref %outputs "out")))))
> + (home-page "https://www.rust-lang.org")
> + (synopsis "Rust bootstrap")
“Rust bootstrapping meta-package”
OK with appropriate changes, thanks!
Ludo’.
next prev parent reply other threads:[~2016-12-13 22:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-11 17:25 [PATCH 00/12] Rust build system v2 David Craven
2016-12-11 17:25 ` [PATCH 01/12] upstream: Use a the first url from urls when find2 returns #f David Craven
2016-12-13 17:25 ` Ludovic Courtès
2016-12-13 20:07 ` David Craven
2016-12-13 22:22 ` Ludovic Courtès
2016-12-11 17:25 ` [PATCH 02/12] build-system: Add cargo build system David Craven
2016-12-13 17:26 ` Ludovic Courtès
2016-12-30 11:08 ` Danny Milosavljevic
2017-01-01 14:42 ` David Craven
2016-12-11 17:25 ` [PATCH 03/12] import: utils: Add some utilities David Craven
2016-12-13 17:29 ` Ludovic Courtès
2016-12-13 18:09 ` David Craven
2016-12-11 17:25 ` [PATCH 04/12] import: Add importer for rust crates David Craven
2016-12-13 17:30 ` Ludovic Courtès
2016-12-11 17:25 ` [PATCH 05/12] import: Add updater " David Craven
2016-12-13 17:30 ` Ludovic Courtès
2016-12-11 17:25 ` [PATCH 06/12] gnu: llvm: Enable install utils David Craven
2016-12-13 22:50 ` Ludovic Courtès
2016-12-11 17:25 ` [PATCH 07/12] gnu: Add rust bootstrap binaries David Craven
2016-12-13 22:44 ` Ludovic Courtès [this message]
2016-12-11 17:25 ` [PATCH 08/12] gnu: Add rustc David Craven
2016-12-13 22:47 ` Ludovic Courtès
2016-12-11 17:25 ` [PATCH 09/12] gnu: Add rust-libc David Craven
2016-12-13 22:48 ` Ludovic Courtès
2016-12-11 17:25 ` [PATCH 10/12] RECURSIVE IMPORTER wip David Craven
2016-12-13 22:49 ` Ludovic Courtès
2016-12-11 17:25 ` [PATCH 11/12] gnu: Add rust-rand David Craven
2016-12-13 22:50 ` Ludovic Courtès
2017-01-03 0:52 ` Danny Milosavljevic
2016-12-11 17:25 ` [PATCH 12/12] gnu: Add cargo David Craven
2016-12-13 22:51 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m27mot1.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).