From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 07/12] gnu: Add rust bootstrap binaries.
Date: Tue, 13 Dec 2016 23:44:58 +0100
Message-ID: <874m27mot1.fsf@gnu.org>
References: <20161211172537.23315-1-david@craven.ch>
	<20161211172537.23315-8-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36476)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cGvoq-0007rg-LU
	for guix-devel@gnu.org; Tue, 13 Dec 2016 17:45:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cGvon-0004T5-5A
	for guix-devel@gnu.org; Tue, 13 Dec 2016 17:45:08 -0500
In-Reply-To: <20161211172537.23315-8-david@craven.ch> (David Craven's message
	of "Sun, 11 Dec 2016 18:25:32 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> skribis:

> * gnu/packages/rust.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add rust.scm.

There are a couple of comments from
<https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00158.html>
that remain valid, I think.  Could you double-check?

> +(define (system->rust-platform system)
> +  (cond
> +   ((string-prefix? "x86_64" system) "x86_64-unknown-linux-gnu")
> +   ((string-prefix? "i686" system) "i686-unknown-linux-gnu")
> +   (else #f)))

I think you can remove this procedure and use =E2=80=98nix-system->gnu-trip=
let=E2=80=99
instead.

> +    (inputs
> +     ;; FIXME: Use system gcc:lib. Does gcc "lib" need to be
> +     ;; added to %final-inputs?
> +     `(("gcc:lib" ,gcc "lib")

Use (canonical-package gcc).

> +(define-public rust-bootstrap
> +  (package
> +    (name "rust-bootstrap")
> +    (version %rust-bootstrap-binaries-version)
> +    (source #f)
> +    (build-system trivial-build-system)
> +    (propagated-inputs
> +     ;; XXX: guix size shows a size of zero. Are propagated inputs not
> +     ;; counted?
> +     `(("rustc-bootstrap" ,rustc-bootstrap)
> +       ("cargo-bootstrap" ,cargo-bootstrap)))
> +    (arguments
> +     `(#:builder
> +       (begin (mkdir (assoc-ref %outputs "out")))))
> +    (home-page "https://www.rust-lang.org")
> +    (synopsis "Rust bootstrap")

=E2=80=9CRust bootstrapping meta-package=E2=80=9D

OK with appropriate changes, thanks!

Ludo=E2=80=99.