From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: 01/01: nginx: berlin: Disable narinfo caching altogether.
Date: Sun, 24 Jun 2018 00:20:59 +0200 [thread overview]
Message-ID: <874lhtw3ec.fsf@gnu.org> (raw)
In-Reply-To: <874lhu8qwt.fsf@netris.org> (Mark H. Weaver's message of "Fri, 22 Jun 2018 17:14:42 -0400")
Hello,
Mark H Weaver <mhw@netris.org> skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Mark H Weaver <mhw@netris.org> skribis:
>>
>>> ludo@gnu.org (Ludovic Courtès) writes:
>>>
>>>> civodul pushed a commit to branch master
>>>> in repository maintenance.
>>>>
>>>> commit 8379ba4119e51151d93589a6ef57cb159d94e9f2
>>>> Author: Ludovic Courtès <ludo@gnu.org>
>>>> Date: Thu Jun 21 11:41:06 2018 +0200
>>>>
>>>> nginx: berlin: Disable narinfo caching altogether.
>>>>
>>>> This is a followup to ebbe4c7f402b6d9cf9c6c2ecf120f49697ab2c49.
>>>>
>>>> * hydra/nginx/berlin-locations.conf (.narinfo): Disable caching.
>>>> * hydra/nginx/berlin.conf: Remove 'proxy_cache_path' directive
>>>> for narinfos.
>>>
>>> What's the rationale for this change?
>>
>> From commit ebbe4c7f402b6d9cf9c6c2ecf120f49697ab2c49:
>>
>> Somehow nginx appeared to be caching narinfos for longer than needed,
>> which defeated the atime-based cache eviction strategy of 'guix
>> publish'.
>>
>> In this case, I noticed on berlin that nginx was caching 404s for
>> narinfos longer than expected, for reasons I could not elucidate. Plus
>> there’s this atime story.
>
> Although you didn't mention it here, I now remember one reason why it's
> a problem for narinfos to be in the cache longer than expected: because
> if a narinfo is available but the corresponding NAR isn't, it causes
> problems on the client side. If that's still the case, then it
> certainly justifies this change.
Yes, that too.
We’ll see how it goes and if it performs badly let’s revert or adjust.
Ludo’.
prev parent reply other threads:[~2018-06-23 22:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180621094438.32617.70405@vcs0.savannah.gnu.org>
[not found] ` <20180621094439.636F520498@vcs0.savannah.gnu.org>
2018-06-21 20:06 ` 01/01: nginx: berlin: Disable narinfo caching altogether Mark H Weaver
2018-06-21 22:06 ` Ludovic Courtès
2018-06-22 21:14 ` Mark H Weaver
2018-06-23 22:20 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lhtw3ec.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).