From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: 01/01: nginx: berlin: Disable narinfo caching altogether.
Date: Sun, 24 Jun 2018 00:20:59 +0200
Message-ID: <874lhtw3ec.fsf@gnu.org>
References: <20180621094438.32617.70405@vcs0.savannah.gnu.org>
	<20180621094439.636F520498@vcs0.savannah.gnu.org>
	<87sh5f9a6c.fsf@netris.org> <878t776bha.fsf@gnu.org>
	<874lhu8qwt.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43762)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1fWqty-0003rI-3a
	for guix-devel@gnu.org; Sat, 23 Jun 2018 18:21:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1fWqtx-0007DZ-48
	for guix-devel@gnu.org; Sat, 23 Jun 2018 18:21:02 -0400
In-Reply-To: <874lhu8qwt.fsf@netris.org> (Mark H. Weaver's message of "Fri, 22
	Jun 2018 17:14:42 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Hello,

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>
>> Mark H Weaver <mhw@netris.org> skribis:
>>
>>> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>>>
>>>> civodul pushed a commit to branch master
>>>> in repository maintenance.
>>>>
>>>> commit 8379ba4119e51151d93589a6ef57cb159d94e9f2
>>>> Author: Ludovic Court=C3=A8s <ludo@gnu.org>
>>>> Date:   Thu Jun 21 11:41:06 2018 +0200
>>>>
>>>>     nginx: berlin: Disable narinfo caching altogether.
>>>>=20=20=20=20=20
>>>>     This is a followup to ebbe4c7f402b6d9cf9c6c2ecf120f49697ab2c49.
>>>>=20=20=20=20=20
>>>>     * hydra/nginx/berlin-locations.conf (.narinfo): Disable caching.
>>>>     * hydra/nginx/berlin.conf: Remove 'proxy_cache_path' directive
>>>>     for narinfos.
>>>
>>> What's the rationale for this change?
>>
>> From commit ebbe4c7f402b6d9cf9c6c2ecf120f49697ab2c49:
>>
>>     Somehow nginx appeared to be caching narinfos for longer than needed,
>>     which defeated the atime-based cache eviction strategy of 'guix
>>     publish'.
>>
>> In this case, I noticed on berlin that nginx was caching 404s for
>> narinfos longer than expected, for reasons I could not elucidate.  Plus
>> there=E2=80=99s this atime story.
>
> Although you didn't mention it here, I now remember one reason why it's
> a problem for narinfos to be in the cache longer than expected: because
> if a narinfo is available but the corresponding NAR isn't, it causes
> problems on the client side.  If that's still the case, then it
> certainly justifies this change.

Yes, that too.

We=E2=80=99ll see how it goes and if it performs badly let=E2=80=99s revert=
 or adjust.

Ludo=E2=80=99.