From: Mathieu Othacehe <othacehe@gnu.org>
To: raid5atemyhomework <raid5atemyhomework@protonmail.com>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: Adding Substitute Mirrors page to installer
Date: Tue, 01 Jun 2021 10:30:46 +0200 [thread overview]
Message-ID: <874kei6l6x.fsf@gnu.org> (raw)
In-Reply-To: <YbKRML5AOIWSpO6ZPerykaBn-bdM7aKTb8oHX5oLbgiQ6Pvg0v7OvAGcl3ppyABHafLnuN2P9TL73LDZ1i8xvpjhzcslRY3SntILZoPYvtc=@protonmail.com> (raid5atemyhomework@protonmail.com's message of "Thu, 22 Apr 2021 05:23:08 +0000")
Hello,
Sorry again for the long delay.
> Of course, it feels somewhat dirty, as there is a need to read the configuration file.
> It would be cleaner if a page could affect the field created by a previous page.
Yes I agree. In the meantime, I think that the configuration file read
is an acceptable solution.
> I think Less is More, and deploying an installer with a simple "select one
> mirror" page *now* will cover 90% of use-cases, and we can add the more
> complicated page later when there is more time.
Seems fair.
I ran the installer tests with this command: make check-system
TESTS="gui-installed-os". The following error is reported:
--8<---------------cut here---------------start------------->8---
conversation expecting pattern ((quote list-selection) ((quote title) "Partitioning method") ((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...)))
/gnu/store/h38i2hvaqy9bd0sbn9isdfzl7m56mngr-shepherd-marionette.scm:1:1718: ERROR:
1. &pattern-not-matched:
pattern: ((quote list-selection) ((quote title) "Partitioning method") ((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...)))
sexp: (list-selection (title "Substitute mirror") (multiple-choices? #f) (items ("https://ci.guix.gnu.org (Berlin, official Guix substitute server)" "https://mirror.sjtu.edu.cn/guix (China, SJTU)")))
Backtrace:
2 (primitive-load "/gnu/store/n6z0h9gxfkzrvsfcsbpd05kxxcx?")
In ice-9/eval.scm:
191:35 1 (_ #f)
619:8 0 (_ #(#<directory (guile-user) 7ffff3bb3f00> #<variabl?>))
ice-9/eval.scm:619:8: Throw to key `marionette-eval-failure' with args `((quote (choose-partitioning installer-socket #:encrypted? #f #:passphrase "thepassphrase" #:uefi-support? #f)))'.
note: keeping build directory `/tmp/guix-build-installation.drv-0'
builder for `/gnu/store/wp95pl7l9jfjwj6dpizhmbsfb85alzi1-installation.drv' failed with exit code 1
build of /gnu/store/wp95pl7l9jfjwj6dpizhmbsfb85alzi1-installation.drv failed
View build log at '/var/log/guix/drvs/wp/95pl7l9jfjwj6dpizhmbsfb85alzi1-installation.drv.bz2'.
--8<---------------cut here---------------end--------------->8---
As explained here:
https://lists.gnu.org/archive/html/guix-patches/2021-05/msg00819.html,
you need to introduce a new "list-selection" conversation item in the
"choose-services" procedure of the (gnu installer tests) module to fix
this issue.
Thanks,
Mathieu
next prev parent reply other threads:[~2021-06-01 8:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 2:46 Adding Substitute Mirrors page to installer raid5atemyhomework
2021-03-09 2:34 ` raid5atemyhomework
2021-03-09 8:05 ` Pierre Neidhardt
2021-03-10 9:49 ` raid5atemyhomework
2021-03-15 16:14 ` Ludovic Courtès
2021-03-15 22:53 ` zimoun
2021-03-16 1:07 ` raid5atemyhomework
2021-03-16 15:55 ` raid5atemyhomework
2021-03-27 6:48 ` raid5atemyhomework
2021-03-27 8:56 ` Mathieu Othacehe
2021-04-01 9:22 ` Mathieu Othacehe
2021-04-22 5:23 ` raid5atemyhomework
2021-05-13 1:27 ` raid5atemyhomework
2021-05-31 9:42 ` raid5atemyhomework
2021-05-31 10:04 ` Maxime Devos
2021-06-01 6:39 ` raid5atemyhomework
2021-06-01 8:30 ` Mathieu Othacehe [this message]
2021-06-02 14:44 ` raid5atemyhomework
2021-07-23 14:53 ` raid5atemyhomework
2021-07-23 15:10 ` Tobias Geerinckx-Rice
2021-07-23 15:21 ` raid5atemyhomework
2021-08-01 9:42 ` raid5atemyhomework
2021-08-01 12:28 ` Christopher Baines
2021-12-01 6:11 ` raid5atemyhomework
2021-12-01 8:16 ` zimoun
2021-12-01 22:49 ` raid5atemyhomework
2021-12-02 9:36 ` zimoun
2021-12-02 10:20 ` Jonathan Brielmaier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kei6l6x.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=guix-devel@gnu.org \
--cc=raid5atemyhomework@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).