From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ANK3L0bwtWAcOgEAgWs5BA (envelope-from ) for ; Tue, 01 Jun 2021 10:31:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cLwbK0bwtWArXwAA1q6Kng (envelope-from ) for ; Tue, 01 Jun 2021 08:31:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EB5EF14200 for ; Tue, 1 Jun 2021 10:31:01 +0200 (CEST) Received: from localhost ([::1]:39874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnzng-0002Z8-AO for larch@yhetil.org; Tue, 01 Jun 2021 04:31:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnznW-0002Yz-CK for guix-devel@gnu.org; Tue, 01 Jun 2021 04:30:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50204) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnznU-0006R5-G0; Tue, 01 Jun 2021 04:30:48 -0400 Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=38928 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnznU-0002MI-77; Tue, 01 Jun 2021 04:30:48 -0400 From: Mathieu Othacehe To: raid5atemyhomework Subject: Re: Adding Substitute Mirrors page to installer References: <87blbsah0x.fsf@ambrevar.xyz> <-WVvn-rIc2HXdunUeEp6YfVQ9WkU-JsP_sAdLNK4ebx5YUTZ0-lSxWF2MGWOTGpqCvfil-JSAW1n-_82UQlRSXM5Qmb2ajaTYsa_EFUJ6o4=@protonmail.com> <3YQTy8cg8z-IZkxgM7lJSk8ZeolHbf4t7_HPw9Q8GCkx1lP7CXrbdtPZ9Hvyo--NvKXyr9W2iv82d8lL2T0NQPpTPhDbBFo3_3jQ3eAdAEI=@protonmail.com> <87o8eys6ki.fsf@gnu.org> Date: Tue, 01 Jun 2021 10:30:46 +0200 In-Reply-To: (raid5atemyhomework@protonmail.com's message of "Thu, 22 Apr 2021 05:23:08 +0000") Message-ID: <874kei6l6x.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "guix-devel@gnu.org" Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622536262; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=5DWaZnp6C7mtg4g5SAhIXjirxpkkpL6zWhXJreK1p6c=; b=iqcujE9rlvNZpsiek0394p5u+dCDhNNup402PS/nigszHG0nj6H6w9lSGjjaDk0XLcKzrU qJBwYH0TKceYm6IySl3MXnh9nP/VXSX6vZ+8gdwBsin3y0jzCv5JGBoUDf43eFUmaxrV1r ZFZ8yNX3m8YZURT7ffdyncpUFgSDxUMwY+kSt3Q9dQaA+aCjgG7O9J7FOzwmxhM3u4Kgqj eC1J1aEoBV3UUqeE6iin5ky3+jAnF2whXZRsE24XYx4VqqwsYk+WXbM3xqurSrpE6BrXAi gVbsyHDd2wcedeaN4Qx5mnYhnzwNRwi9p4bHZJkobTTolQO2BaYtEU8dfVog8w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622536262; a=rsa-sha256; cv=none; b=dh6GqtX3Yc9rSsxLiZMNRgtgyq84nnSs5BDIBqTkDmc8uX7XqoFFSPrc6RrXg3M17+GN/s OBz2UxXM+2WSnUPYfQz3UjWnw9I8V6rzDTGUmFbeHLiPwhWHbNoANKQfJfnCFwoAKAzrxV gKMcZFDJYUMjaWdaEw1VXp5YmvKGTcSldejxvgvZB0IYp9YHAcstk634ZFz3Ad6DYTkAMm k7RQhFc1PQ7v6eV3CdNDLda+HwcS+t8ACCa8fkT2Yx3kJK5ZQbuQSnjki/9xyBDCoM4APa KNMI2ZNMJxPNDUA1wZl0H6yOsKDMeqyaJsU4rwIUhRdq8YPHomDgwkZ9eRDyrA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: EB5EF14200 X-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: 8zDZkHVXgj05 Hello, Sorry again for the long delay. > Of course, it feels somewhat dirty, as there is a need to read the configuration file. > It would be cleaner if a page could affect the field created by a previous page. Yes I agree. In the meantime, I think that the configuration file read is an acceptable solution. > I think Less is More, and deploying an installer with a simple "select one > mirror" page *now* will cover 90% of use-cases, and we can add the more > complicated page later when there is more time. Seems fair. I ran the installer tests with this command: make check-system TESTS="gui-installed-os". The following error is reported: --8<---------------cut here---------------start------------->8--- conversation expecting pattern ((quote list-selection) ((quote title) "Partitioning method") ((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...))) /gnu/store/h38i2hvaqy9bd0sbn9isdfzl7m56mngr-shepherd-marionette.scm:1:1718: ERROR: 1. &pattern-not-matched: pattern: ((quote list-selection) ((quote title) "Partitioning method") ((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...))) sexp: (list-selection (title "Substitute mirror") (multiple-choices? #f) (items ("https://ci.guix.gnu.org (Berlin, official Guix substitute server)" "https://mirror.sjtu.edu.cn/guix (China, SJTU)"))) Backtrace: 2 (primitive-load "/gnu/store/n6z0h9gxfkzrvsfcsbpd05kxxcx?") In ice-9/eval.scm: 191:35 1 (_ #f) 619:8 0 (_ #(# #)) ice-9/eval.scm:619:8: Throw to key `marionette-eval-failure' with args `((quote (choose-partitioning installer-socket #:encrypted? #f #:passphrase "thepassphrase" #:uefi-support? #f)))'. note: keeping build directory `/tmp/guix-build-installation.drv-0' builder for `/gnu/store/wp95pl7l9jfjwj6dpizhmbsfb85alzi1-installation.drv' failed with exit code 1 build of /gnu/store/wp95pl7l9jfjwj6dpizhmbsfb85alzi1-installation.drv failed View build log at '/var/log/guix/drvs/wp/95pl7l9jfjwj6dpizhmbsfb85alzi1-installation.drv.bz2'. --8<---------------cut here---------------end--------------->8--- As explained here: https://lists.gnu.org/archive/html/guix-patches/2021-05/msg00819.html, you need to introduce a new "list-selection" conversation item in the "choose-services" procedure of the (gnu installer tests) module to fix this issue. Thanks, Mathieu