unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] Fix gfortran (?)
@ 2016-03-21 13:16 Ricardo Wurmus
  2016-03-28  6:50 ` Ricardo Wurmus
  2016-03-28 16:05 ` Ludovic Courtès
  0 siblings, 2 replies; 3+ messages in thread
From: Ricardo Wurmus @ 2016-03-21 13:16 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

Hi Guix,

with this patch applied I can build randomjungle without having to add
the “lib” output of gfortran to the package inputs.

This is related to the changes I pushed in commit 82f145e to fix
bug#19733, which seems to have broken the build of randomjungle and
slepc, among others.

Is this acceptable?  Should we do this for all gfortran variants then?

~~ Ricardo


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-gfortran-Disable-separate-lib-output.patch --]
[-- Type: text/x-patch, Size: 846 bytes --]

From f3d97b7f1f2b597f7f74b2f59212f241a87fa602 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Date: Mon, 21 Mar 2016 14:09:45 +0100
Subject: [PATCH] gnu: gfortran: Disable separate "lib" output.

* gnu/packages/gcc.scm (gfortran): Disable separate "lib" output.
---
 gnu/packages/gcc.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gcc.scm b/gnu/packages/gcc.scm
index 1df5150..341c30c 100644
--- a/gnu/packages/gcc.scm
+++ b/gnu/packages/gcc.scm
@@ -474,7 +474,8 @@ as the 'native-search-paths' field."
 
 (define-public gfortran
   (custom-gcc gcc "gfortran" '("fortran")
-              %generic-search-paths))
+              %generic-search-paths
+              #:separate-lib-output? #f))
 
 (define-public gfortran-5
   (custom-gcc gcc-5 "gfortran" '("fortran")
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix gfortran (?)
  2016-03-21 13:16 [PATCH] Fix gfortran (?) Ricardo Wurmus
@ 2016-03-28  6:50 ` Ricardo Wurmus
  2016-03-28 16:05 ` Ludovic Courtès
  1 sibling, 0 replies; 3+ messages in thread
From: Ricardo Wurmus @ 2016-03-28  6:50 UTC (permalink / raw)
  To: guix-devel


Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:

> with this patch applied I can build randomjungle without having to add
> the “lib” output of gfortran to the package inputs.
>
> This is related to the changes I pushed in commit 82f145e to fix
> bug#19733, which seems to have broken the build of randomjungle and
> slepc, among others.
>
> Is this acceptable?  Should we do this for all gfortran variants then?

Ping :)

This seems to be the easiest way to fix gfortran.

~~ Ricardo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix gfortran (?)
  2016-03-21 13:16 [PATCH] Fix gfortran (?) Ricardo Wurmus
  2016-03-28  6:50 ` Ricardo Wurmus
@ 2016-03-28 16:05 ` Ludovic Courtès
  1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2016-03-28 16:05 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: guix-devel

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> with this patch applied I can build randomjungle without having to add
> the “lib” output of gfortran to the package inputs.

‘randomjungle’ currently fails at configure time like this:

--8<---------------cut here---------------start------------->8---
checking for pow... no
checking for pow in -lm... no
configure: WARNING: cannot find library containing definition of pow
--8<---------------cut here---------------end--------------->8---

Is this due to the fact that libgcc_s.so is not found?  I vaguely recall
discussions like this.

> From f3d97b7f1f2b597f7f74b2f59212f241a87fa602 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Mon, 21 Mar 2016 14:09:45 +0100
> Subject: [PATCH] gnu: gfortran: Disable separate "lib" output.
>
> * gnu/packages/gcc.scm (gfortran): Disable separate "lib" output.
> ---
>  gnu/packages/gcc.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gcc.scm b/gnu/packages/gcc.scm
> index 1df5150..341c30c 100644
> --- a/gnu/packages/gcc.scm
> +++ b/gnu/packages/gcc.scm
> @@ -474,7 +474,8 @@ as the 'native-search-paths' field."
>  
>  (define-public gfortran
>    (custom-gcc gcc "gfortran" '("fortran")
> -              %generic-search-paths))
> +              %generic-search-paths
> +              #:separate-lib-output? #f))

This is easier than augmenting the “lib” spec.

The downside is that things compiled with gfortran would retain a
reference to the whole ‘gfortran’ package (the closure of which is
217 MiB, vs. 72 MiB for gfortran:lib.)

Ludo’.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-03-28 16:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-21 13:16 [PATCH] Fix gfortran (?) Ricardo Wurmus
2016-03-28  6:50 ` Ricardo Wurmus
2016-03-28 16:05 ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).