From: ludo@gnu.org (Ludovic Courtès)
To: jmi2k@openmailbox.org
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add libtermkey, vis and lua-lpeg packages
Date: Sun, 04 Dec 2016 22:24:52 +0100 [thread overview]
Message-ID: <8737i35qvv.fsf@gnu.org> (raw)
In-Reply-To: <61a19eb41fa4eb66339c14519f0bcefd@openmailbox.org> (jmi2k@openmailbox.org's message of "Sat, 03 Dec 2016 00:04:55 +0100")
Hello, and welcome!
Thanks for sharing patches! They are almost ready to be applied, I’ll
just point out a few issues. You can look at
<https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>
for more info.
jmi2k@openmailbox.org skribis:
> From 792a9ff128f397bcf9eac1f113e84ebe29f2eb2f Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Jos=C3=A9=20Miguel=20S=C3=A1nchez=20Garc=C3=ADa?=
> <jmi2k@openmailbox.org>
> Date: Fri, 2 Dec 2016 23:39:08 +0100
> Subject: [PATCH] Add vis, libtermkey and lua-lpeg packages
As noted in the page above, we use “GNU ChangeLog” style for commit
logs. You can see examples in ‘git log’.
> ---
> gnu/packages/libtermkey.scm | 36 ++++++++++++++++++++++++++++++++++++
> gnu/packages/lua-lpeg.scm | 33 +++++++++++++++++++++++++++++++++
> gnu/packages/vis.scm | 37 +++++++++++++++++++++++++++++++++++++
Please make one patch per package.
> +++ b/gnu/packages/libtermkey.scm
> @@ -0,0 +1,36 @@
> +(define-module (gnu packages libtermkey)
Could you add the license header (as in the other files) with a
copyright line for yourself?
> + (description (string-append
> + "Libtermkey handles all the necessary logic to recognise special keys, "
> + "UTF-8 combining, and so on, with a simple interface."))
Please use a literal string instead of ‘string-append’. That way the
description will be picked up for translation.
Also, if you haven’t done already, make sure to run ‘guix lint’ for
these packages. It’s usually a good way to catch tiny issues.
Could you send updated patches? If minor problems remain we can fix
them for you if you want.
Thank you!
Ludo’.
prev parent reply other threads:[~2016-12-04 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 22:45 [PATCH] Add libtermkey, vis and lua-lpeg packages jmi2k
2016-12-02 23:04 ` jmi2k
2016-12-04 21:24 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737i35qvv.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=jmi2k@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).