From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add libtermkey, vis and lua-lpeg packages
Date: Sun, 04 Dec 2016 22:24:52 +0100
Message-ID: <8737i35qvv.fsf@gnu.org>
References: <2a0b5340eedb9caac760781b8df71906@openmailbox.org>
	<61a19eb41fa4eb66339c14519f0bcefd@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37140)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cDeHK-0005pr-Do
	for guix-devel@gnu.org; Sun, 04 Dec 2016 16:24:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cDeHG-0007UC-VZ
	for guix-devel@gnu.org; Sun, 04 Dec 2016 16:24:58 -0500
In-Reply-To: <61a19eb41fa4eb66339c14519f0bcefd@openmailbox.org>
	(jmi2k@openmailbox.org's message of "Sat, 03 Dec 2016 00:04:55 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: jmi2k@openmailbox.org
Cc: guix-devel@gnu.org

Hello, and welcome!

Thanks for sharing patches!  They are almost ready to be applied, I=E2=80=
=99ll
just point out a few issues.  You can look at
<https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>
for more info.

jmi2k@openmailbox.org skribis:

> From 792a9ff128f397bcf9eac1f113e84ebe29f2eb2f Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?Jos=3DC3=3DA9=3D20Miguel=3D20S=3DC3=3DA1nchez=3D20Garc=
=3DC3=3DADa?=3D
>  <jmi2k@openmailbox.org>
> Date: Fri, 2 Dec 2016 23:39:08 +0100
> Subject: [PATCH] Add vis, libtermkey and lua-lpeg packages

As noted in the page above, we use =E2=80=9CGNU ChangeLog=E2=80=9D style fo=
r commit
logs.  You can see examples in =E2=80=98git log=E2=80=99.

> ---
>  gnu/packages/libtermkey.scm | 36 ++++++++++++++++++++++++++++++++++++
>  gnu/packages/lua-lpeg.scm   | 33 +++++++++++++++++++++++++++++++++
>  gnu/packages/vis.scm        | 37 +++++++++++++++++++++++++++++++++++++

Please make one patch per package.

> +++ b/gnu/packages/libtermkey.scm
> @@ -0,0 +1,36 @@
> +(define-module (gnu packages libtermkey)

Could you add the license header (as in the other files) with a
copyright line for yourself?

> +    (description (string-append
> +      "Libtermkey handles all the necessary logic to recognise special k=
eys, "
> +      "UTF-8 combining, and so on, with a simple interface."))

Please use a literal string instead of =E2=80=98string-append=E2=80=99.  Th=
at way the
description will be picked up for translation.

Also, if you haven=E2=80=99t done already, make sure to run =E2=80=98guix l=
int=E2=80=99 for
these packages.  It=E2=80=99s usually a good way to catch tiny issues.

Could you send updated patches?  If minor problems remain we can fix
them for you if you want.

Thank you!

Ludo=E2=80=99.