From: Jan Nieuwenhuizen <janneke@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: 05/36: vm: Make the device node procedure a parameter.
Date: Fri, 01 May 2020 08:07:01 +0200 [thread overview]
Message-ID: <87368kur22.fsf@gnu.org> (raw)
In-Reply-To: <87y2qcmymt.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 30 Apr 2020 23:50:34 +0200")
Ludovic Courtès writes:
>> vm: Make the device node procedure a parameter.
>> #:bootcfg-drv grub.cfg
>> #:bootloader grub-bootloader
>> #:register-closures? #f
>> + #:device-nodes 'hurd
>> #:extra-directives hurd-directives))
>
> On ‘core-updates’, there’s already #:device-nodes 'hurd, though not on
> the same line.
>
> I think we can drop this patch, no?
Oops, sure; dropped.
We may even want to move this (and "friends") into the qemu-image
declaration itself; in a much later patch on wip-hurd-vm I have
(define* qemu-image #:key
[...]
- (file-system-type "ext4")
- (file-system-options '())
- (device-nodes 'linux)
+ (file-system-type (if (hurd-target?) "ext2" "ext4"))
+ (file-system-options
+ (if (hurd-target?) '("-o" "hurd") '()))
+ (device-nodes (if (hurd-target?) 'hurd 'linux))
Having linux-specific defaults in a generic function is kind of awkward;
we would need to change all callers, or ...
Well, that's for later to be sure!
Greetings,
janeke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
next prev parent reply other threads:[~2020-05-01 6:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200427101927.7020.76060@vcs0.savannah.gnu.org>
[not found] ` <20200427101942.B725620A5E@vcs0.savannah.gnu.org>
2020-04-30 21:48 ` 02/36: gnu: guix: Use gnutls-3.6.13 when cross-compiling Ludovic Courtès
2020-05-01 7:22 ` Jan Nieuwenhuizen
[not found] ` <20200427101943.A4BDD20A5E@vcs0.savannah.gnu.org>
2020-04-30 21:50 ` 05/36: vm: Make the device node procedure a parameter Ludovic Courtès
2020-05-01 6:07 ` Jan Nieuwenhuizen [this message]
2020-05-03 20:34 ` Ludovic Courtès
[not found] ` <20200427101943.F251E20A5E@vcs0.savannah.gnu.org>
2020-04-30 21:51 ` 06/36: gnu: hurd: Fix references to /bin/w Ludovic Courtès
2020-05-01 6:07 ` Jan Nieuwenhuizen
[not found] ` <20200427101944.46D0C20A5E@vcs0.savannah.gnu.org>
2020-04-30 21:52 ` 07/36: gnu: hurd: Use default Qemu guest ip: 10.0.2.15 Ludovic Courtès
2020-05-01 6:07 ` Jan Nieuwenhuizen
[not found] ` <20200427101944.86DE020BC2@vcs0.savannah.gnu.org>
2020-04-30 21:53 ` 08/36: gnu: hurd: Add NFS support Ludovic Courtès
2020-05-01 6:14 ` Jan Nieuwenhuizen
[not found] ` <20200427101945.023D020BC4@vcs0.savannah.gnu.org>
2020-04-30 21:55 ` 09/36: gnu: Add libtirpc/hurd Ludovic Courtès
2020-05-01 6:15 ` Jan Nieuwenhuizen
2020-04-30 21:56 ` branch wip-hurd-vm created (now fdb35e3) Ludovic Courtès
2020-05-01 7:02 ` Jan Nieuwenhuizen
[not found] ` <20200427101946.414C420A5E@vcs0.savannah.gnu.org>
2020-04-30 22:03 ` 13/36: services: Add hurd-console-service-type Ludovic Courtès
2020-05-01 15:16 ` Jan Nieuwenhuizen
2020-05-01 20:03 ` Jan Nieuwenhuizen
2020-05-03 20:39 ` Ludovic Courtès
2020-05-03 20:55 ` Jan Nieuwenhuizen
[not found] ` <20200427101947.E79D320A5E@vcs0.savannah.gnu.org>
2020-04-30 22:07 ` 18/36: services: hurd: Add dummy loopback Ludovic Courtès
2020-05-01 15:15 ` Jan Nieuwenhuizen
2020-05-03 20:50 ` Ludovic Courtès
2020-05-03 22:15 ` Jan Nieuwenhuizen
2020-05-05 9:23 ` Ludovic Courtès
2020-05-05 9:38 ` Vincent Legoll
2020-05-06 14:06 ` Ludovic Courtès
2020-05-05 12:46 ` Jan Nieuwenhuizen
2020-05-06 14:09 ` Ludovic Courtès
[not found] ` <20200427101948.9B2B220A5E@vcs0.savannah.gnu.org>
2020-04-30 22:25 ` 20/36: system: hurd: Add the Shepherd Ludovic Courtès
2020-05-01 10:28 ` Jan Nieuwenhuizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87368kur22.fsf@gnu.org \
--to=janneke@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).