From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GDquBIy8q14DeQAA0tVLHw (envelope-from ) for ; Fri, 01 May 2020 06:07:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id lNPbAZW8q17MYgAA1q6Kng (envelope-from ) for ; Fri, 01 May 2020 06:07:17 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1C8C3941238 for ; Fri, 1 May 2020 06:07:16 +0000 (UTC) Received: from localhost ([::1]:32892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUOpQ-0004v0-9P for larch@yhetil.org; Fri, 01 May 2020 02:07:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60824) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUOpH-0004uo-NU for guix-devel@gnu.org; Fri, 01 May 2020 02:07:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38136) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUOpG-0001Rt-9D; Fri, 01 May 2020 02:07:06 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=60090 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jUOpE-0002SC-Ps; Fri, 01 May 2020 02:07:05 -0400 From: Jan Nieuwenhuizen To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: 05/36: vm: Make the device node procedure a parameter. Organization: AvatarAcademy.nl References: <20200427101927.7020.76060@vcs0.savannah.gnu.org> <20200427101943.A4BDD20A5E@vcs0.savannah.gnu.org> <87y2qcmymt.fsf@gnu.org> X-Url: http://AvatarAcademy.nl Date: Fri, 01 May 2020 08:07:01 +0200 In-Reply-To: <87y2qcmymt.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 30 Apr 2020 23:50:34 +0200") Message-ID: <87368kur22.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49462833401368]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.16), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; HAS_ORG_HEADER(0.00)[]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; FROM_NEQ_ENVFROM(0.00)[janneke@gnu.org,guix-devel-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[gnu.org:email,joyofsource.com:url,avataracademy.com:url,lilypond.org:url]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[gnu.org]; HAS_LIST_UNSUB(-0.01)[]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: 8p36wbbnwC5Q Ludovic Court=C3=A8s writes: >> vm: Make the device node procedure a parameter. >> #:bootcfg-drv grub.cfg >> #:bootloader grub-bootloader >> #:register-closures? #f >> + #:device-nodes 'hurd >> #:extra-directives hurd-directives)) > > On =E2=80=98core-updates=E2=80=99, there=E2=80=99s already #:device-nodes= 'hurd, though not on > the same line. > > I think we can drop this patch, no? Oops, sure; dropped. We may even want to move this (and "friends") into the qemu-image declaration itself; in a much later patch on wip-hurd-vm I have (define* qemu-image #:key [...] - (file-system-type "ext4") - (file-system-options '()) - (device-nodes 'linux) + (file-system-type (if (hurd-target?) "ext2" "ext4")) + (file-system-options + (if (hurd-target?) '("-o" "hurd") '())) + (device-nodes (if (hurd-target?) 'hurd 'linux)) Having linux-specific defaults in a generic function is kind of awkward; we would need to change all callers, or ... Well, that's for later to be sure! Greetings, janeke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com