[PATCH] gnu: Add older ruby 1.8.7

[PATCH] gnu: Add older ruby 1.8.7

[Pjotr Prins]

    * gnu/packages/ruby.scm: Added older Ruby 1.8.7
---
 gnu/packages/ruby.scm |   27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index ac751f5..0b10b87 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -89,6 +89,33 @@ a focus on simplicity and productivity.")
     (home-page "https://ruby-lang.org")
     (license license:ruby)))
 
+(define-public ruby-1.8
+  (package (inherit ruby)
+    (name "ruby")
+    (version "1.8.7")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "ftp://ftp.ruby-lang.org/pub/ruby/1.8/"
+                           name "-" version "-p374.tar.bz2"))
+     (sha256
+      (base32
+       "1qq7khilwkayrhwmzlxk83scrmiqfi7lgsn4c63znyvz2c1lgqxl"))))
+    (arguments
+     `(#:test-target "test"
+       #:parallel-tests? #f
+       #:phases
+        (alist-cons-before
+         'configure 'replace-bin-sh
+         (lambda _
+           (substitute* '("Makefile.in"
+                          "ext/pty/pty.c"
+                          "io.c"
+                          "lib/mkmf.rb"
+                          "process.c")
+             (("/bin/sh") (which "sh"))))
+         %standard-phases)))))
+
 (define-public ruby-i18n
   (package
     (name "ruby-i18n")
-- 
1.7.10.4

Re: [PATCH] gnu: Add older ruby 1.8.7

[Mark H Weaver]

Pjotr Prins <pjotr.public12@thebird.nl> writes:

>     * gnu/packages/ruby.scm: Added older Ruby 1.8.7
> ---
>  gnu/packages/ruby.scm |   27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index ac751f5..0b10b87 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -89,6 +89,33 @@ a focus on simplicity and productivity.")
>      (home-page "https://ruby-lang.org")
>      (license license:ruby)))
>  
> +(define-public ruby-1.8
> +  (package (inherit ruby)
> +    (name "ruby")
> +    (version "1.8.7")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "ftp://ftp.ruby-lang.org/pub/ruby/1.8/"
> +                           name "-" version "-p374.tar.bz2"))

What's that "-p374" in the file name?  If it's a patch level, then I
think it should be part of the version string.

     Mark

Re: [PATCH] gnu: Add older ruby 1.8.7

[Pjotr Prins]

Good point. How do we use patch levels anyway?

On Sat, Oct 25, 2014 at 08:17:58PM -0400, Mark H Weaver wrote:
> What's that "-p374" in the file name?  If it's a patch level, then I
> think it should be part of the version string.
> 
>      Mark
> 

Re: [PATCH] gnu: Add older ruby 1.8.7

[Mark H Weaver]

Mark H Weaver wrote:
> What's that "-p374" in the file name?  If it's a patch level, then I
> think it should be part of the version string.

Pjotr Prins <pjotr.public12@thebird.nl> wrote:
> Good point. How do we use patch levels anyway?

I'm sorry, I don't understand your question.  What does it mean to "use"
a patch level?

      Mark

Re: [PATCH] gnu: Add older ruby 1.8.7

[Pjotr Prins]

On Sun, Oct 26, 2014 at 12:34:49AM -0400, Mark H Weaver wrote:
> Mark H Weaver wrote:
> > What's that "-p374" in the file name?  If it's a patch level, then I
> > think it should be part of the version string.
> 
> Pjotr Prins <pjotr.public12@thebird.nl> wrote:
> > Good point. How do we use patch levels anyway?
> 
> I'm sorry, I don't understand your question.  What does it mean to "use"
> a patch level?

We have package-name and package-version. Why not package-patch-level?
I don't think it should be part of version.

Pj.

Re: [PATCH] gnu: Add older ruby 1.8.7

[Ludovic Courtès]

Similar to what we do for Bash, the ‘version’ field should be
“1.8.7.374”, which would preserve ordering.

Ludo’.

Re: [PATCH] gnu: Add older ruby 1.8.7

[Mark H Weaver]

Pjotr Prins <pjotr.public12@thebird.nl> writes:
> We have package-name and package-version. Why not package-patch-level?
> I don't think it should be part of version.

I agree with Ludovic.  The patch-level is conceptually part of the
version.

We have a fair bit of program logic, APIs, and user interface elements
that assume that there's only one 'version' field.  All of those would
need to be changed to support an additional 'patch-level' field.  Doing
all of that work would require a compelling argument.  I don't see one.

      Mark

Re: [PATCH] gnu: Add older ruby 1.8.7

[Pjotr Prins]

On Sun, Oct 26, 2014 at 03:00:48PM +0100, Ludovic Courtès wrote:
> Similar to what we do for Bash, the version field should be
> 1.8.7.374, which would preserve ordering.

The filename contains 1.8.7-p374. So, can I use that for the version?

Pj.

Re: [PATCH] gnu: Add older ruby 1.8.7

[Ludovic Courtès]

Pjotr Prins <pjotr.public12@thebird.nl> skribis:

> On Sun, Oct 26, 2014 at 03:00:48PM +0100, Ludovic Courtès wrote:
>> Similar to what we do for Bash, the version field should be
>> 1.8.7.374, which would preserve ordering.
>
> The filename contains 1.8.7-p374. So, can I use that for the version?

I have a preference for 1.8.7.374, but 1.8.7-p374 would work as well.

Ludo’.