Re: [PATCH] Core sanity and taking build options from environment.

[ludo@gnu.org (Ludovic Courtès)]

Deck Pickard <deck.r.pickard@gmail.com> skribis:

> On 28 Nov 2014 22:52, "Ludovic Courtès" <ludo@gnu.org> wrote:
>>
>> Deck Pickard <deck.r.pickard@gmail.com> skribis:
>>
>> > From 3693753aefc27b5a68a2b762feeebc41320e79ef Mon Sep 17 00:00:00 2001
>> > From: nebuli <nebu@kipple>
>> > Date: Wed, 26 Nov 2014 19:51:37 +0100
>> > Subject: [PATCH 1/2] guix: Default to daemon's default --cores setting
> of 1.
>>
>> I think most of the time one would prefer to use all the available cores
>> when building.  WDYT?
>>
>
> Perhaps for one-off 15 minutes worth of compiles it's a OK,

I’ve always used as many cores as available, and it’s definitely
been OK, FWIW.

> but not for hours of work. And you are creating more confusion by
> having different defaults from guix-daemon.

Right, I’ve changed guix-daemon’s default to 0, which at least will
avoid confusion.

> From a4ec02e09f2bc1d4ad33e82ac9052439bdece6d0 Mon Sep 17 00:00:00 2001
> From: nebuli <nebu@kipple>
> Date: Sun, 30 Nov 2014 17:47:22 +0100
> Subject: [PATCH] guix: scripts: Add GUIX_BUILD_OPTIONS environment handling.
>
> * doc/guix.texi: Mention in the 'Invoking guix build' section.
> * guix/scripts/archive.scm: (append args (environment-build-options)
> * guix/scripts/build.scm: Ditto.
> * guix/scripts/environment.scm: Ditto.
> * guix/scripts/package.scm: Ditto.
> * guix/scripts/system.scm: Ditto.
> * guix/ui.scm (environment-build-options): New function.
> * guix/utils.scm (arguments-from-environment-variable): New function.

I tweaked guix.texi, updated test-env.in, added a test, and pushed it.

Thanks!

Ludo’.