From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Core sanity and taking build options from environment.
Date: Sun, 30 Nov 2014 18:55:46 +0100
Message-ID: <871tokpo7x.fsf@gnu.org>
References: <CAJ41eezW0KRVu6TBE0UeUVnNgqFSxgwML5p+FDd5h_bH3N_ghg@mail.gmail.com>
	<CAJ41eezNiGrwADtd_+fS76m2rQivqwuTz2B2if1RYLt+YLRdtg@mail.gmail.com>
	<87vblzyoun.fsf@inria.fr>
	<CAJ41eezEtwQM6FKJYnt=Lk1APHmHor9OFX8B6NtqN5sHQ8oyxw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48795)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Xv8iy-0007yV-Lq
	for guix-devel@gnu.org; Sun, 30 Nov 2014 12:56:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Xv8ir-0005ZP-DA
	for guix-devel@gnu.org; Sun, 30 Nov 2014 12:55:56 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:44320)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Xv8ir-0005ZI-6K
	for guix-devel@gnu.org; Sun, 30 Nov 2014 12:55:49 -0500
In-Reply-To: <CAJ41eezEtwQM6FKJYnt=Lk1APHmHor9OFX8B6NtqN5sHQ8oyxw@mail.gmail.com>
	(Deck Pickard's message of "Sun, 30 Nov 2014 18:17:36 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Deck Pickard <deck.r.pickard@gmail.com>
Cc: guix-devel@gnu.org

Deck Pickard <deck.r.pickard@gmail.com> skribis:

> On 28 Nov 2014 22:52, "Ludovic Court=C3=A8s" <ludo@gnu.org> wrote:
>>
>> Deck Pickard <deck.r.pickard@gmail.com> skribis:
>>
>> > From 3693753aefc27b5a68a2b762feeebc41320e79ef Mon Sep 17 00:00:00 2001
>> > From: nebuli <nebu@kipple>
>> > Date: Wed, 26 Nov 2014 19:51:37 +0100
>> > Subject: [PATCH 1/2] guix: Default to daemon's default --cores setting
> of 1.
>>
>> I think most of the time one would prefer to use all the available cores
>> when building.  WDYT?
>>
>
> Perhaps for one-off 15 minutes worth of compiles it's a OK,

I=E2=80=99ve always used as many cores as available, and it=E2=80=99s defin=
itely
been OK, FWIW.

> but not for hours of work. And you are creating more confusion by
> having different defaults from guix-daemon.

Right, I=E2=80=99ve changed guix-daemon=E2=80=99s default to 0, which at le=
ast will
avoid confusion.

> From a4ec02e09f2bc1d4ad33e82ac9052439bdece6d0 Mon Sep 17 00:00:00 2001
> From: nebuli <nebu@kipple>
> Date: Sun, 30 Nov 2014 17:47:22 +0100
> Subject: [PATCH] guix: scripts: Add GUIX_BUILD_OPTIONS environment handli=
ng.
>
> * doc/guix.texi: Mention in the 'Invoking guix build' section.
> * guix/scripts/archive.scm: (append args (environment-build-options)
> * guix/scripts/build.scm: Ditto.
> * guix/scripts/environment.scm: Ditto.
> * guix/scripts/package.scm: Ditto.
> * guix/scripts/system.scm: Ditto.
> * guix/ui.scm (environment-build-options): New function.
> * guix/utils.scm (arguments-from-environment-variable): New function.

I tweaked guix.texi, updated test-env.in, added a test, and pushed it.

Thanks!

Ludo=E2=80=99.