Re: [PATCH] tests: Use '.' and not 'source' which is a Bashism.

[ludo@gnu.org (Ludovic Courtès)]

taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis:

> John Darrington <john@darrington.wattle.id.au> writes:
>
>> Since we use bash, I don't think it matters if we have constructs
>> which don't work on the traditional bourne shell.
>
> This is about building Guix though, which should work on any POSIX
> system (approximately at least?) with the dependencies listed in the
> README.

Yes.

> By the way it seems that wasn't the only issue in the test.  Here is a
> better patch, this time tested on Debian with /bin/sh set to dash:
>
>
> From f165e9a91118936e72f7df836446541c093c8329 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <taylanbayirli@gmail.com>
> Date: Wed, 6 May 2015 20:13:31 +0200
> Subject: [PATCH] tests: Fix etc/profile test.
>
> * tests/profiles.scm ("etc/profile"): Unset GUIX_PROFILE before sourcing
>   etc/profile.  Use '.' instead of 'source' for sourcing, since the latter is
>   a Bashism.  Call 'echo $PATH' instead of using the output of 'set' to
>   determine whether PATH is set, because the output of 'set' differs between
>   shells.

Good catch!  Looks good to me.

Could you move the explanations (after “since” and “because”) as
comments in the source, and push afterwards?

Thank you!

Ludo’.