From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] tests: Use '.' and not 'source' which is a Bashism.
Date: Wed, 06 May 2015 22:17:27 +0200
Message-ID: <871titsboo.fsf@gnu.org>
References: <87pp6dk1rs.fsf@taylan.uni.cx> <20150506193212.GA10069@intra>
	<87lhh1jwpn.fsf@taylan.uni.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58934)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yq5l8-0006PI-5N
	for guix-devel@gnu.org; Wed, 06 May 2015 16:17:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yq5l4-0002m9-RP
	for guix-devel@gnu.org; Wed, 06 May 2015 16:17:34 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33714)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Yq5l4-0002m5-OO
	for guix-devel@gnu.org; Wed, 06 May 2015 16:17:30 -0400
In-Reply-To: <87lhh1jwpn.fsf@taylan.uni.cx> ("Taylan Ulrich
	\=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\=
	message of "Wed, 06 May 2015 22:08:04 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Taylan Ulrich =?utf-8?Q?=22Bay=C4=B1rl=C4=B1?=
	=?utf-8?Q?=2FKammer=22?= <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org

taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") skribis:

> John Darrington <john@darrington.wattle.id.au> writes:
>
>> Since we use bash, I don't think it matters if we have constructs
>> which don't work on the traditional bourne shell.
>
> This is about building Guix though, which should work on any POSIX
> system (approximately at least?) with the dependencies listed in the
> README.

Yes.

> By the way it seems that wasn't the only issue in the test.  Here is a
> better patch, this time tested on Debian with /bin/sh set to dash:
>
>
> From f165e9a91118936e72f7df836446541c093c8329 Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?Taylan=3D20Ulrich=3D20Bay=3DC4=3DB1rl=3DC4=3DB1/Kammer?=
=3D
>  <taylanbayirli@gmail.com>
> Date: Wed, 6 May 2015 20:13:31 +0200
> Subject: [PATCH] tests: Fix etc/profile test.
>
> * tests/profiles.scm ("etc/profile"): Unset GUIX_PROFILE before sourcing
>   etc/profile.  Use '.' instead of 'source' for sourcing, since the latte=
r is
>   a Bashism.  Call 'echo $PATH' instead of using the output of 'set' to
>   determine whether PATH is set, because the output of 'set' differs betw=
een
>   shells.

Good catch!  Looks good to me.

Could you move the explanations (after =E2=80=9Csince=E2=80=9D and =E2=80=
=9Cbecause=E2=80=9D) as
comments in the source, and push afterwards?

Thank you!

Ludo=E2=80=99.