* [PATCH] gnu: add vte-ng
@ 2016-03-29 23:52 Mckinley Olsen
2016-03-30 21:54 ` Alex Kost
0 siblings, 1 reply; 6+ messages in thread
From: Mckinley Olsen @ 2016-03-29 23:52 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1.1: Type: text/plain, Size: 78 bytes --]
Package vte-ng, which is needed by termite terminal (which I hope to
package)
[-- Attachment #1.2: Type: text/html, Size: 103 bytes --]
[-- Attachment #2: 0001-gnu-add-vte-ng.patch --]
[-- Type: application/octet-stream, Size: 1926 bytes --]
From c06b9fe54d33d6c8624426771fbb52606f751f58 Mon Sep 17 00:00:00 2001
From: McKinley Olsen <mck.olsen@gmail.com>
Date: Mon, 28 Mar 2016 15:03:06 -0600
Subject: [PATCH] gnu: add vte-ng.
* gnu/packages/gnome.scm (vte-ng): added vte-ng package.
---
gnu/packages/gnome.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index eebb547..376ee74 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1755,6 +1755,37 @@ gnome-terminal, but can also be used to embed a console/terminal in games,
editors, IDEs, etc.")
(license license:lgpl2.1+)))
+(define-public vte-ng
+ (package
+ (inherit vte)
+ (name "vte-ng")
+ (version "0.42.4.a")
+ (native-inputs
+ `(("gtk-doc" ,gtk-doc)
+ ("gperf" ,gperf)
+ ("autoconf" ,autoconf)
+ ("automake" ,automake)
+ ("libtool" ,libtool)
+ ,@(package-native-inputs vte)))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url (string-append "https://github.com/thestinger/"
+ name
+ ".git"))
+ (commit version)))
+ (file-name (string-append name "-" version))
+ (sha256
+ (base32
+ "1w91lz30j5lrskp9ds5j3nn27m5mpdpn7nlcvf5y1w63mpmjg8k1"))))
+ (arguments
+ `(#:phases (modify-phases %standard-phases
+ (add-after 'unpack 'bootstrap
+ (lambda _
+ (setenv "NOCONFIGURE" "true")
+ (zero? (system* "sh" "autogen.sh")))))))))
+
+
;; provides vte 2.90, required for some terminal emulators
;; tilda bug: https://github.com/lanoxx/tilda/issues/94
;; pantheon-terminal bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=788021
--
2.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: add vte-ng
2016-03-29 23:52 [PATCH] gnu: add vte-ng Mckinley Olsen
@ 2016-03-30 21:54 ` Alex Kost
2016-04-09 8:42 ` Alex Kost
0 siblings, 1 reply; 6+ messages in thread
From: Alex Kost @ 2016-03-30 21:54 UTC (permalink / raw)
To: Mckinley Olsen; +Cc: guix-devel
Mckinley Olsen (2016-03-30 02:52 +0300) wrote:
> Package vte-ng, which is needed by termite terminal (which I hope to
> package)
Hello, this is a great patch for the first package! I have only a
couple of nitpicks and one real question.
> From c06b9fe54d33d6c8624426771fbb52606f751f58 Mon Sep 17 00:00:00 2001
> From: McKinley Olsen <mck.olsen@gmail.com>
> Date: Mon, 28 Mar 2016 15:03:06 -0600
> Subject: [PATCH] gnu: add vte-ng.
Capital "Add" ----------^
> * gnu/packages/gnome.scm (vte-ng): added vte-ng package.
We write it like this:
* gnu/packages/gnome.scm (vte-ng): New variable.
> ---
> gnu/packages/gnome.scm | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index eebb547..376ee74 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -1755,6 +1755,37 @@ gnome-terminal, but can also be used to embed a console/terminal in games,
> editors, IDEs, etc.")
> (license license:lgpl2.1+)))
>
> +(define-public vte-ng
> + (package
> + (inherit vte)
> + (name "vte-ng")
> + (version "0.42.4.a")
> + (native-inputs
> + `(("gtk-doc" ,gtk-doc)
> + ("gperf" ,gperf)
> + ("autoconf" ,autoconf)
> + ("automake" ,automake)
> + ("libtool" ,libtool)
> + ,@(package-native-inputs vte)))
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url (string-append "https://github.com/thestinger/"
> + name
> + ".git"))
> + (commit version)))
Why do you use git instead of the latest tagged source?:
https://github.com/thestinger/vte-ng/archive/0.44.0.a.tar.gz
> + (file-name (string-append name "-" version))
> + (sha256
> + (base32
> + "1w91lz30j5lrskp9ds5j3nn27m5mpdpn7nlcvf5y1w63mpmjg8k1"))))
> + (arguments
> + `(#:phases (modify-phases %standard-phases
> + (add-after 'unpack 'bootstrap
> + (lambda _
> + (setenv "NOCONFIGURE" "true")
> + (zero? (system* "sh" "autogen.sh")))))))))
I think it also would be good to add its own synopsis/description to
make it clear how it differs from "vte".
--
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: add vte-ng
2016-03-30 21:54 ` Alex Kost
@ 2016-04-09 8:42 ` Alex Kost
[not found] ` <CAM5ENzCezyQd9xniEPrMTf9PCviqBcDwqKt+0OLR+5ybFXZgww@mail.gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Alex Kost @ 2016-04-09 8:42 UTC (permalink / raw)
To: Mckinley Olsen; +Cc: guix-devel
Alex Kost (2016-03-31 00:54 +0300) wrote:
> Mckinley Olsen (2016-03-30 02:52 +0300) wrote:
>
>> Package vte-ng, which is needed by termite terminal (which I hope to
>> package)
>
> Hello, this is a great patch for the first package! I have only a
> couple of nitpicks and one real question.
>
>> From c06b9fe54d33d6c8624426771fbb52606f751f58 Mon Sep 17 00:00:00 2001
>> From: McKinley Olsen <mck.olsen@gmail.com>
>> Date: Mon, 28 Mar 2016 15:03:06 -0600
>> Subject: [PATCH] gnu: add vte-ng.
> Capital "Add" ----------^
>
>> * gnu/packages/gnome.scm (vte-ng): added vte-ng package.
>
> We write it like this:
>
> * gnu/packages/gnome.scm (vte-ng): New variable.
>
>> ---
>> gnu/packages/gnome.scm | 31 +++++++++++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>>
>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>> index eebb547..376ee74 100644
>> --- a/gnu/packages/gnome.scm
>> +++ b/gnu/packages/gnome.scm
>> @@ -1755,6 +1755,37 @@ gnome-terminal, but can also be used to embed a console/terminal in games,
>> editors, IDEs, etc.")
>> (license license:lgpl2.1+)))
>>
>> +(define-public vte-ng
>> + (package
>> + (inherit vte)
>> + (name "vte-ng")
>> + (version "0.42.4.a")
>> + (native-inputs
>> + `(("gtk-doc" ,gtk-doc)
>> + ("gperf" ,gperf)
>> + ("autoconf" ,autoconf)
>> + ("automake" ,automake)
>> + ("libtool" ,libtool)
>> + ,@(package-native-inputs vte)))
>> + (source (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url (string-append "https://github.com/thestinger/"
>> + name
>> + ".git"))
>> + (commit version)))
>
>
> Why do you use git instead of the latest tagged source?:
>
> https://github.com/thestinger/vte-ng/archive/0.44.0.a.tar.gz
>
>> + (file-name (string-append name "-" version))
>> + (sha256
>> + (base32
>> + "1w91lz30j5lrskp9ds5j3nn27m5mpdpn7nlcvf5y1w63mpmjg8k1"))))
>> + (arguments
>> + `(#:phases (modify-phases %standard-phases
>> + (add-after 'unpack 'bootstrap
>> + (lambda _
>> + (setenv "NOCONFIGURE" "true")
>> + (zero? (system* "sh" "autogen.sh")))))))))
>
> I think it also would be good to add its own synopsis/description to
> make it clear how it differs from "vte".
Ping! :-)
Could you please send an updated patch with synopsis/description and
with the latest release tarball instead of the git checkout (or explain
in a commentary why a specific git commit is needed).
Also, I'm sorry, but I'm not going to build it, as I don't want to build
'texlive' (vte-ng → gtk-doc → dblatex → texlive). I hope someone else
will do :-)
--
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: add vte-ng
[not found] ` <CAM5ENzCezyQd9xniEPrMTf9PCviqBcDwqKt+0OLR+5ybFXZgww@mail.gmail.com>
@ 2016-04-10 7:42 ` Alex Kost
2016-05-31 20:41 ` Mckinley Olsen
0 siblings, 1 reply; 6+ messages in thread
From: Alex Kost @ 2016-04-10 7:42 UTC (permalink / raw)
To: Mckinley Olsen; +Cc: guix-devel
Mckinley Olsen (2016-04-09 21:10 +0300) wrote:
> Sorry, I'm new to mailing lists; hope this gets to the right place
Oops, it wasn't Cc-ed to guix-devel list, but since I'm replying, the
others will see it anyway.
> I used the git checkout, as I started writing termite's package first
> and realized it needed a recursive checkout; of course I copied over
> that implementation to here. Thanks for the suggestion to use the
> tarball, I've made that change
>
> I used the version I did because I was using the package definition
> in Nix as a guideline. I've worked through packaging a slightly more
> up-to-date version (submitted patch to update pcre2 to required
> version), but am stuck on getting versions 0.43.91 and newer packaged
> due to an error (vteconv.cc:774:40: error: missing sentinel in
> function call [-Werror=format=]), which I believe was caused by this
> change: https://bugzilla.gnome.org/show_bug.cgi?id=762863
>
> I'm quite new to the gnu build system, so it has taken me some time
>
> Sorry I haven't been able to get the newest packaged up. I've just
> found that the gnome-updates branch contains some code working
> through the exact error I'm seeing with vte-ng, so I might reach out
> for them or wait for it to be merged.
Ah, I think it's ok to wait for gnome-updates merge. Thanks for working
on the new packages!
--
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: add vte-ng
2016-04-10 7:42 ` Alex Kost
@ 2016-05-31 20:41 ` Mckinley Olsen
2016-06-01 13:30 ` 宋文武
0 siblings, 1 reply; 6+ messages in thread
From: Mckinley Olsen @ 2016-05-31 20:41 UTC (permalink / raw)
To: Alex Kost; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 1728 bytes --]
Hey Alex, I'm hoping this patch is up to snuff.
I've changed the package definition to depend on the latest tagged
source and provided a synopsis & description specific to vte-ng.
Let me know if you have any other concerns that need to be addressed.
Thanks!
On Sun, Apr 10, 2016 at 1:42 AM, Alex Kost <alezost@gmail.com> wrote:
> Mckinley Olsen (2016-04-09 21:10 +0300) wrote:
>
>> Sorry, I'm new to mailing lists; hope this gets to the right place
>
> Oops, it wasn't Cc-ed to guix-devel list, but since I'm replying, the
> others will see it anyway.
>
>> I used the git checkout, as I started writing termite's package first
>> and realized it needed a recursive checkout; of course I copied over
>> that implementation to here. Thanks for the suggestion to use the
>> tarball, I've made that change
>>
>> I used the version I did because I was using the package definition
>> in Nix as a guideline. I've worked through packaging a slightly more
>> up-to-date version (submitted patch to update pcre2 to required
>> version), but am stuck on getting versions 0.43.91 and newer packaged
>> due to an error (vteconv.cc:774:40: error: missing sentinel in
>> function call [-Werror=format=]), which I believe was caused by this
>> change: https://bugzilla.gnome.org/show_bug.cgi?id=762863
>>
>> I'm quite new to the gnu build system, so it has taken me some time
>>
>> Sorry I haven't been able to get the newest packaged up. I've just
>> found that the gnome-updates branch contains some code working
>> through the exact error I'm seeing with vte-ng, so I might reach out
>> for them or wait for it to be merged.
>
> Ah, I think it's ok to wait for gnome-updates merge. Thanks for working
> on the new packages!
>
> --
> Alex
[-- Attachment #2: 0001-gnu-packages-gnome.scm-vte-ng-New-variable.patch --]
[-- Type: application/octet-stream, Size: 2115 bytes --]
From 5fa75edd3e03839dc7fc81134a9bd37072409f88 Mon Sep 17 00:00:00 2001
From: McKinley Olsen <mck.olsen@gmail.com>
Date: Tue, 31 May 2016 14:28:44 -0600
Subject: [PATCH] * gnu/packages/gnome.scm (vte-ng): New variable.
---
gnu/packages/gnome.scm | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 0d9c946..265fd04 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1787,6 +1787,40 @@ gnome-terminal, but can also be used to embed a console/terminal in games,
editors, IDEs, etc.")
(license license:lgpl2.1+)))
+(define-public vte-ng
+ (package
+ (inherit vte)
+ (name "vte-ng")
+ (version "0.44.1.b")
+ (native-inputs
+ `(("gtk-doc" ,gtk-doc)
+ ("gperf" ,gperf)
+ ("autoconf" ,autoconf)
+ ("automake" ,automake)
+ ("libtool" ,libtool)
+ ,@(package-native-inputs vte)))
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "https://github.com/thestinger/"
+ name
+ "/archive/"
+ version
+ ".tar.gz"))
+ (file-name (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "1mhz4i1qkdlrs49vgm7nsrb60lry9v6wsgwsmji7fln1nyrp1pag"))))
+ (arguments
+ `(#:configure-flags '("CXXFLAGS=-Wformat=0")
+ #:phases (modify-phases %standard-phases
+ (add-after 'unpack 'bootstrap
+ (lambda _
+ (setenv "NOCONFIGURE" "true")
+ (zero? (system* "sh" "autogen.sh")))))))
+ (synopsis "Enhanced VTE terminal widget")
+ (description "VTE, with additional functions exposed for keyboard text
+ selection and URL hints.")))
+
;; provides vte 2.90, required for some terminal emulators
;; tilda bug: https://github.com/lanoxx/tilda/issues/94
;; pantheon-terminal bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=788021
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: add vte-ng
2016-05-31 20:41 ` Mckinley Olsen
@ 2016-06-01 13:30 ` 宋文武
0 siblings, 0 replies; 6+ messages in thread
From: 宋文武 @ 2016-06-01 13:30 UTC (permalink / raw)
To: Mckinley Olsen; +Cc: guix-devel, Alex Kost
Mckinley Olsen <mck.olsen@gmail.com> writes:
> Hey Alex, I'm hoping this patch is up to snuff.
> I've changed the package definition to depend on the latest tagged
> source and provided a synopsis & description specific to vte-ng.
> Let me know if you have any other concerns that need to be addressed.
> Thanks!
>
> From 5fa75edd3e03839dc7fc81134a9bd37072409f88 Mon Sep 17 00:00:00 2001
> From: McKinley Olsen <mck.olsen@gmail.com>
> Date: Tue, 31 May 2016 14:28:44 -0600
> Subject: [PATCH] * gnu/packages/gnome.scm (vte-ng): New variable.
First line should be: "gnu: Add vte-ng."
>
> [...]
> + name
> + "/archive/"
> + version
> + ".tar.gz"))
^^^^ put these into one line.
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + #:phases (modify-phases %standard-phases
> + (add-after 'unpack 'bootstrap
> + (lambda _
> + (setenv "NOCONFIGURE" "true")
> + (zero? (system* "sh" "autogen.sh")))))))
> + (synopsis "Enhanced VTE terminal widget")
> + (description "VTE, with additional functions exposed for keyboard text
> + selection and URL hints.")))
I expand "VTE" a bit.
Pushed, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-01 13:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-29 23:52 [PATCH] gnu: add vte-ng Mckinley Olsen
2016-03-30 21:54 ` Alex Kost
2016-04-09 8:42 ` Alex Kost
[not found] ` <CAM5ENzCezyQd9xniEPrMTf9PCviqBcDwqKt+0OLR+5ybFXZgww@mail.gmail.com>
2016-04-10 7:42 ` Alex Kost
2016-05-31 20:41 ` Mckinley Olsen
2016-06-01 13:30 ` 宋文武
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).