unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH 1/2] gnu: password-store: Delete build phase
@ 2016-12-10  9:55 Christopher Baines
  2016-12-10  9:55 ` [PATCH 2/2] gnu: password-store: Don't run tests in parallel Christopher Baines
  0 siblings, 1 reply; 3+ messages in thread
From: Christopher Baines @ 2016-12-10  9:55 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/password-utils.scm (password-store): Remove the build
  phase, as it is unused.
---
 gnu/packages/password-utils.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index cf030ec..bdb3acf 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -280,6 +280,7 @@ any X11 window.")
      '(#:phases
        (modify-phases %standard-phases
          (delete 'configure)
+         (delete 'build)
          (add-after 'install 'wrap-path
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out"))
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] gnu: password-store: Don't run tests in parallel
  2016-12-10  9:55 [PATCH 1/2] gnu: password-store: Delete build phase Christopher Baines
@ 2016-12-10  9:55 ` Christopher Baines
  2016-12-10 13:11   ` Marius Bakke
  0 siblings, 1 reply; 3+ messages in thread
From: Christopher Baines @ 2016-12-10  9:55 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/password-utils.scm (password-store): Don't run tests in
  parallel, as it causes them to hang and the build to timeout.
---
 gnu/packages/password-utils.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index bdb3acf..98669a6 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -291,6 +291,7 @@ any X11 window.")
                (wrap-program (string-append out "/bin/pass")
                  `("PATH" ":" prefix (,(string-join path ":"))))))))
        #:make-flags (list "CC=gcc" (string-append "PREFIX=" %output))
+       #:parallel-tests? #f
        #:test-target "test"))
     (inputs
      `(("getopt" ,util-linux)
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] gnu: password-store: Don't run tests in parallel
  2016-12-10  9:55 ` [PATCH 2/2] gnu: password-store: Don't run tests in parallel Christopher Baines
@ 2016-12-10 13:11   ` Marius Bakke
  0 siblings, 0 replies; 3+ messages in thread
From: Marius Bakke @ 2016-12-10 13:11 UTC (permalink / raw)
  To: Christopher Baines, guix-devel

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

Christopher Baines <mail@cbaines.net> writes:

> * gnu/packages/password-utils.scm (password-store): Don't run tests in
>   parallel, as it causes them to hang and the build to timeout.
> ---
>  gnu/packages/password-utils.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
> index bdb3acf..98669a6 100644
> --- a/gnu/packages/password-utils.scm
> +++ b/gnu/packages/password-utils.scm
> @@ -291,6 +291,7 @@ any X11 window.")
>                 (wrap-program (string-append out "/bin/pass")
>                   `("PATH" ":" prefix (,(string-join path ":"))))))))
>         #:make-flags (list "CC=gcc" (string-append "PREFIX=" %output))
> +       #:parallel-tests? #f
>         #:test-target "test"))
>      (inputs
>       `(("getopt" ,util-linux)
> -- 
> 2.10.2

Thanks for these patches! I added a code comment to the later one.

Pushed as a77f03608498de5e93560da8aac0cb8bf7cec7a7.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-12-10 13:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-10  9:55 [PATCH 1/2] gnu: password-store: Delete build phase Christopher Baines
2016-12-10  9:55 ` [PATCH 2/2] gnu: password-store: Don't run tests in parallel Christopher Baines
2016-12-10 13:11   ` Marius Bakke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).