unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: <guix-devel@gnu.org>
Subject: Flagging gexps that import (guix config) & co.
Date: Fri, 06 Nov 2020 14:07:36 +0100	[thread overview]
Message-ID: <871rh6zl9j.fsf@inria.fr> (raw)

Hello Guix!

Yesterday I noticed that some of our system tests would be
non-deterministic in the sense that their .drv file name would differ
from machine to machine.  The .drv computed at ci.guix.gnu.org for a
given test was different from that I had on my machine.

This is not the first time we see it: it was due to services or tests
importing the host’s (guix config) module or (ice-9 …) modules on the
build side.  Since those modules can vary between users, importing them
leads to discrepancies like that.

(guix gexp) now emits a warning when these modules are imported:

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=ca465a9c8454289b7aded22719cd5d919e441780

I thought it shouldn’t be an error because it’s a matter of policy.
It looks like this:

  gnu/services/monitoring.scm:398:4: warning: importing module (ice-9 rdelim) from the host

where the line and column indicate the start of the gexp importing the
module(s).

Having done that, I fixed a few services and tests.  Now one can again run:

  ./pre-inst-env guix weather -m etc/system-tests.scm --display-missing

to quickly see what fraction of the system tests is successful on
ci.guix.gnu.org.

Ludo’.


                 reply	other threads:[~2020-11-06 13:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rh6zl9j.fsf@inria.fr \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).