From: zimoun <zimon.toutoune@gmail.com>
To: "Léo Le Bouter" <lle-bout@zaclys.net>, guix-devel@gnu.org
Subject: Re: Security patching and the branching workflow: a new security-updates branch
Date: Sat, 27 Mar 2021 13:29:14 +0100 [thread overview]
Message-ID: <86o8f493vp.fsf@gmail.com> (raw)
In-Reply-To: <12b4006a4a28c9678c523ab129945850b4adf37f.camel@zaclys.net>
[-- Attachment #1: Type: text/plain, Size: 3823 bytes --]
Hi Léo,
On Fri, 26 Mar 2021 at 21:10, Léo Le Bouter <lle-bout@zaclys.net> wrote:
> For these reasons, I would like to propose a new branch called
> security-updates that would be based on master where we queue security
> fixes that introduce any arbitrary number of rebuilds without using
> grafts.
>
> We would merge the security-updates branch as soon as there is complete
> substitute availability for the branch and it's future merged version
> within master.
Basically, what you are proposing is more or less staging. The issue is
that the cycles are sometimes longer than expected. The cycle is
defined as 6 weeks for staging. Is it really 6 weeks? Well, It could
be shorter if there is more man power *and* if the build farm is working
better.
About the man power, it is already a good job. Let plot roughly the
number of days between 2 merges between staging and master.
--8<---------------cut here---------------start------------->8---
$ git log --format="%cd|%s" --date=format:"%Y-%m-%d" --after=2019-01-01 \
| grep Merge | grep staging | grep master \
| cut -d'|' -f1 \
> /tmp/staging.txt
--8<---------------cut here---------------end--------------->8---
then this tiny R script:
--8<---------------cut here---------------start------------->8---
$ cat /tmp/dates.R
library("ggplot2")
raw <- read.table("/tmp/staging.txt")
dat <- raw$V1
dates <- data.frame(start=strptime(dat[1:length(dat)-1], format="%Y-%m-%d"),
end=strptime(dat[2:length(dat)], format="%Y-%m-%d"))
dates$diff <- difftime(dates$start, dates$end, units="days")
p <- ggplot(dates, aes(x=start, y=diff)) + geom_point(color='red') + geom_smooth()
ggsave("/tmp/number-of-days-staging-merges.pdf")
--8<---------------cut here---------------end--------------->8---
shows the attached graph. Well, it is variable and the variance and
standard deviation should be considered. The mean is less then 8 days.
Obviously, I can have done a mistake and this should be taken with grain
of salt. My point is: we should root the practise on what we are
already doing and see what are the incremental changes to improve.
For example, staging is not merged since a couple of months. Why?
Because none of us is taking the time to make it. Hard to be close to
the oven and in the same to the mill. :-)
About the build farm, it is doing better and better. Mathieu introduced
some plots [1] and again I think we should explore a bit the data to see
what is the average time to build staging, how many packages are built
on average, etc.
Moreover, priorities have recently been introduced. I do know if we
have enough time elapse to see their impacts. They are per branch,
IIRC, and maybe we could imagine a priority ’properties’ applied for a
package because it is a security update. IIUC, it is not implemented
yet. And as I said elsewhere, “to me, security is important. But it's
no less important than everything *else* that is also important!“, so
personally I am not convinced that security updates deserve a special
treatment compared to a regular update. That’s my opinion. :-)
That’s said, from my point of view, staging or security-updates are only
names but somehow they cover the same idea: update a package with many
dependants and provide the substitutes as soon as it is available.
The key for a better scaling is, IMHO, to tweak what is going to master,
staging and core-updates; as I wrote in [2].
But the real hard part is to collectively make this tough work of
merging branches on the long run.
Cheers,
simon
1: <https://ci.guix.gnu.org/metrics>
2: <https://yhetil.org/guix/86mtv29erk.fsf@gmail.com>
[-- Attachment #2: graph.pdf --]
[-- Type: application/pdf, Size: 11423 bytes --]
next prev parent reply other threads:[~2021-03-27 12:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 20:10 Security patching and the branching workflow: a new security-updates branch Léo Le Bouter
2021-03-26 22:13 ` Christopher Baines
2021-03-26 22:30 ` Léo Le Bouter
2021-03-27 8:56 ` Christopher Baines
2021-03-27 12:29 ` zimoun [this message]
2021-03-27 12:42 ` Léo Le Bouter
2021-03-27 13:56 ` zimoun
2021-03-27 14:14 ` Léo Le Bouter
2021-03-30 11:48 ` zimoun
2021-03-31 0:01 ` Léo Le Bouter
2021-03-31 21:29 ` Ludovic Courtès
2021-04-01 12:44 ` Léo Le Bouter
2021-04-01 14:58 ` Ricardo Wurmus
2021-04-01 15:10 ` Léo Le Bouter
2021-04-01 15:42 ` Léo Le Bouter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o8f493vp.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=guix-devel@gnu.org \
--cc=lle-bout@zaclys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).